Source/platform/geometry/LayoutRect.h - Issue 952273006: Make the constructor of a LayoutRect from an IntRect explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/geometry/LayoutRect.h

Issue 952273006: Make the constructor of a LayoutRect from an IntRect explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/geometry/LayoutRect.h

diff --git a/Source/platform/geometry/LayoutRect.h b/Source/platform/geometry/LayoutRect.h

index 7af11a365ff5a928fcad80aeca663dbc611c2c87..d69671fb2b656c12d89a5d19adf6d7d6ceb176ea 100644

--- a/Source/platform/geometry/LayoutRect.h

+++ b/Source/platform/geometry/LayoutRect.h

@@ -49,7 +49,7 @@ public:

: m_location(LayoutPoint(x, y)), m_size(LayoutSize(width, height)) { }

LayoutRect(const FloatPoint& location, const FloatSize& size)

: m_location(location), m_size(size) { }

- LayoutRect(const IntRect& rect) : m_location(rect.location()), m_size(rect.size()) { }

+ explicit LayoutRect(const IntRect& rect) : m_location(rect.location()), m_size(rect.size()) { }

chrishtr 2015/02/26 18:26:47 Explicit.

explicit LayoutRect(const FloatRect&); // don't do this implicitly since it's lossy