Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 952273005: content: Update crash key and discardable memory usage counter in child process. (Closed)

Created:
5 years, 10 months ago by reveman
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Update crash key and discardable memory usage counter in child process. This is useful when analyzing the discardable memory usage of a specific renderer and the crash key is useful to have in crash reports. BUG=460995 Committed: https://crrev.com/9cdaf33ec68132c021be01826d04b166b6251795 Cr-Commit-Position: refs/heads/master@{#318253}

Patch Set 1 #

Patch Set 2 : Fix DCHECKs #

Patch Set 3 : typo #

Patch Set 4 : make sure crash key and trace counter is updated if needed in dtor #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M content/child/child_discardable_shared_memory_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 1 2 3 4 7 chunks +38 lines, -4 lines 0 comments Download
M content/common/discardable_shared_memory_heap.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/discardable_shared_memory_heap.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
reveman
5 years, 10 months ago (2015-02-25 23:45:56 UTC) #2
Avi (use Gerrit)
lgtm ok https://codereview.chromium.org/952273005/diff/60001/content/child/child_discardable_shared_memory_manager.cc File content/child/child_discardable_shared_memory_manager.cc (right): https://codereview.chromium.org/952273005/diff/60001/content/child/child_discardable_shared_memory_manager.cc#newcode114 content/child/child_discardable_shared_memory_manager.cc:114: // the later only represent the amount ...
5 years, 9 months ago (2015-02-26 16:21:15 UTC) #3
reveman
https://codereview.chromium.org/952273005/diff/60001/content/child/child_discardable_shared_memory_manager.cc File content/child/child_discardable_shared_memory_manager.cc (right): https://codereview.chromium.org/952273005/diff/60001/content/child/child_discardable_shared_memory_manager.cc#newcode114 content/child/child_discardable_shared_memory_manager.cc:114: // the later only represent the amount of memory ...
5 years, 9 months ago (2015-02-26 16:55:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952273005/80001
5 years, 9 months ago (2015-02-26 16:56:20 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-02-26 17:44:00 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 17:45:13 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9cdaf33ec68132c021be01826d04b166b6251795
Cr-Commit-Position: refs/heads/master@{#318253}

Powered by Google App Engine
This is Rietveld 408576698