sky/engine/core/editing/FrameSelection.cpp - Issue 952273003: Make WebView::close not crash and start to fix navigation in SkyShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/FrameSelection.cpp

Issue 952273003: Make WebView::close not crash and start to fix navigation in SkyShell (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/editing/FrameSelection.cpp

diff --git a/sky/engine/core/editing/FrameSelection.cpp b/sky/engine/core/editing/FrameSelection.cpp

index d24777918cd696c10cae6c72018a6bd8224932d1..eb75373089af1a4d20a9b71d05be337caff9ea1a 100644

--- a/sky/engine/core/editing/FrameSelection.cpp

+++ b/sky/engine/core/editing/FrameSelection.cpp

@@ -1141,6 +1141,8 @@ void FrameSelection::prepareForDestruction()

if (view)

view->clearSelection();

+ m_frame = 0;

setSelection(VisibleSelection(), CloseTyping | ClearTypingStyle | DoNotUpdateAppearance);

}

« no previous file with comments | « no previous file | sky/engine/core/script/dart_controller.cc » ('j') | sky/shell/ui/engine.cc » ('J')