Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 952243002: Implement experimental exponentiation operator via desugaring (Closed)

Created:
5 years, 10 months ago by caitp (gmail)
Modified:
4 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement experimental exponentiation operator via desugaring BUG=v8:3915 LOG=N R=

Patch Set 1 #

Total comments: 3

Patch Set 2 : Simplify scanner, inline getting ast_value_factory in parser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -7 lines) Patch
M src/ast.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic-state.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 3 chunks +18 lines, -0 lines 0 comments Download
M src/preparser.h View 7 chunks +40 lines, -2 lines 0 comments Download
M src/scanner.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/scanner.cc View 1 2 chunks +24 lines, -2 lines 0 comments Download
M src/token.h View 3 chunks +4 lines, -2 lines 0 comments Download
A test/mjsunit/harmony/exponentiation.js View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
caitp (gmail)
This version doesn't touch the compiler at all. Note that the changed code is not ...
5 years, 10 months ago (2015-02-25 15:35:34 UTC) #1
arv (Not doing code reviews)
Maybe skip **= until it works as expected? https://codereview.chromium.org/952243002/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/952243002/diff/1/src/parser.cc#newcode524 src/parser.cc:524: AstValueFactory* ...
5 years, 10 months ago (2015-02-25 16:58:25 UTC) #3
caitp (gmail)
I think, despite being observable, the big I'd probably ok if this can't be implemented ...
5 years, 10 months ago (2015-02-25 20:52:59 UTC) #4
caitp (gmail)
5 years, 10 months ago (2015-02-25 20:53:54 UTC) #5
On 2015/02/25 20:52:59, caitp wrote:
> I think, despite being observable, the big I'd probably ok if this can't be
> implemented in the compiler at this time. My personal opinion is, it is a
really
> small impact on the compiler, it makes more sense, it's smaller and it works
> better. Realistically I think it will cause fewer headaches there, rather than
> making the parser crazier.
> 
> If people aren't convinced of either of these, i guess removing the assignment
> op is the thing to do
> 
> https://codereview.chromium.org/952243002/diff/1/src/parser.cc
> File src/parser.cc (right):
> 
> https://codereview.chromium.org/952243002/diff/1/src/parser.cc#newcode524
> src/parser.cc:524: AstValueFactory* ast_value_factory =
> parser_->ast_value_factory();
> On 2015/02/25 16:58:25, arv wrote:
> > just inline this
> 
> Acknowledged.

The bug is* mobile =_=

Powered by Google App Engine
This is Rietveld 408576698