Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/mips64/ic-mips64.cc

Issue 952233002: MIPS64: Improve and fix nan hole checks and canonicalization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 #include "src/v8.h" 6 #include "src/v8.h"
7 7
8 #if V8_TARGET_ARCH_MIPS64 8 #if V8_TARGET_ARCH_MIPS64
9 9
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 // HOLECHECK: guards "A[i] double hole?" 661 // HOLECHECK: guards "A[i] double hole?"
662 // We have to see if the double version of the hole is present. If so 662 // We have to see if the double version of the hole is present. If so
663 // go to the runtime. 663 // go to the runtime.
664 __ Daddu(address, elements, 664 __ Daddu(address, elements,
665 Operand(FixedDoubleArray::kHeaderSize + sizeof(kHoleNanLower32) - 665 Operand(FixedDoubleArray::kHeaderSize + sizeof(kHoleNanLower32) -
666 kHeapObjectTag)); 666 kHeapObjectTag));
667 __ SmiScale(at, key, kPointerSizeLog2); 667 __ SmiScale(at, key, kPointerSizeLog2);
668 __ daddu(address, address, at); 668 __ daddu(address, address, at);
669 __ lw(scratch_value, MemOperand(address)); 669 __ lw(scratch_value, MemOperand(address));
670 __ Branch(&fast_double_without_map_check, ne, scratch_value, 670 __ Branch(&fast_double_without_map_check, ne, scratch_value,
671 Operand(kHoleNanUpper32)); 671 Operand(static_cast<int32_t>(kHoleNanUpper32)));
672 __ JumpIfDictionaryInPrototypeChain(receiver, elements_map, scratch_value, 672 __ JumpIfDictionaryInPrototypeChain(receiver, elements_map, scratch_value,
673 slow); 673 slow);
674 674
675 __ bind(&fast_double_without_map_check); 675 __ bind(&fast_double_without_map_check);
676 __ StoreNumberToDoubleElements(value, key, 676 __ StoreNumberToDoubleElements(value, key,
677 elements, // Overwritten. 677 elements, // Overwritten.
678 a3, // Scratch regs... 678 a3, // Scratch regs...
679 a4, &transition_double_elements); 679 a4, &transition_double_elements);
680 if (increment_length == kIncrementLength) { 680 if (increment_length == kIncrementLength) {
681 // Add 1 to receiver->length. 681 // Add 1 to receiver->length.
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 patcher.ChangeBranchCondition(ne); 987 patcher.ChangeBranchCondition(ne);
988 } else { 988 } else {
989 DCHECK(Assembler::IsBne(branch_instr)); 989 DCHECK(Assembler::IsBne(branch_instr));
990 patcher.ChangeBranchCondition(eq); 990 patcher.ChangeBranchCondition(eq);
991 } 991 }
992 } 992 }
993 } 993 }
994 } // namespace v8::internal 994 } // namespace v8::internal
995 995
996 #endif // V8_TARGET_ARCH_MIPS64 996 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « no previous file | src/mips64/lithium-codegen-mips64.cc » ('j') | src/mips64/lithium-codegen-mips64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698