Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 952233002: MIPS64: Improve and fix nan hole checks and canonicalization. (Closed)

Created:
5 years, 10 months ago by dusmil.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Improve and fix hole nan checks and canonicalization. TEST=kraken-1.1 benchmark BUG= Committed: https://crrev.com/47e608ab5261c7c222dbef4fab83be43865f784b Cr-Commit-Position: refs/heads/master@{#26861}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/ic/mips64/ic-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +4 lines, -5 lines 1 comment Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
dusmil.imgtec
PTAL.
5 years, 10 months ago (2015-02-25 15:09:25 UTC) #2
balazs.kilvady
lgtm
5 years, 10 months ago (2015-02-25 15:55:49 UTC) #3
paul.l...
LGTM, with a nit (and a question). https://codereview.chromium.org/952233002/diff/1/src/mips64/lithium-codegen-mips64.cc File src/mips64/lithium-codegen-mips64.cc (right): https://codereview.chromium.org/952233002/diff/1/src/mips64/lithium-codegen-mips64.cc#newcode2367 src/mips64/lithium-codegen-mips64.cc:2367: Operand(static_cast<int32_t>(kHoleNanUpper32))); this ...
5 years, 10 months ago (2015-02-25 16:21:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952233002/1
5 years, 10 months ago (2015-02-25 16:36:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 17:09:34 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 17:09:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47e608ab5261c7c222dbef4fab83be43865f784b
Cr-Commit-Position: refs/heads/master@{#26861}

Powered by Google App Engine
This is Rietveld 408576698