Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 952183003: Disable allocator_shim_win for the SyzyASan builds. (Closed)

Created:
5 years, 10 months ago by Sébastien Marchand
Modified:
5 years, 10 months ago
Reviewers:
chrisha, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable allocator_shim_win for the SyzyASan builds. As we're planning to intercept the _heap_init and _heap_term function to control which heap gets used by the crt we need to make sure that libcmt doesn't get patched. R=chrisha@chromium.org BUG= Committed: https://crrev.com/5f627ab827233a87c9b78d29b0a4912a08c0fbb3 Cr-Commit-Position: refs/heads/master@{#318147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Sébastien Marchand
PTAL.
5 years, 10 months ago (2015-02-25 20:35:25 UTC) #1
chrisha
lgtm
5 years, 10 months ago (2015-02-25 20:36:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952183003/1
5 years, 10 months ago (2015-02-25 20:37:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45533)
5 years, 10 months ago (2015-02-25 21:09:52 UTC) #6
Sébastien Marchand
+Scott for owner approval.
5 years, 10 months ago (2015-02-25 21:15:44 UTC) #8
scottmg
lgtm
5 years, 10 months ago (2015-02-25 21:23:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952183003/1
5 years, 10 months ago (2015-02-25 21:25:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 23:35:06 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 23:35:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f627ab827233a87c9b78d29b0a4912a08c0fbb3
Cr-Commit-Position: refs/heads/master@{#318147}

Powered by Google App Engine
This is Rietveld 408576698