Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 952173002: Instrumented libraries: add libjack0 to pulseaudio deps. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: add libjack0 to pulseaudio deps. BUG=459588 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/2bb21b8907e72344084bb02702a8b19a50d9c85f Cr-Commit-Position: refs/heads/master@{#318030}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/instrumented_libraries/install-build-deps.sh View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
earthdok
5 years, 10 months ago (2015-02-25 12:42:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952173002/1
5 years, 10 months ago (2015-02-25 12:43:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 12:44:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2bb21b8907e72344084bb02702a8b19a50d9c85f Cr-Commit-Position: refs/heads/master@{#318030}
5 years, 10 months ago (2015-02-25 12:45:01 UTC) #5
Alexander Potapenko
LGTM https://codereview.chromium.org/952173002/diff/1/third_party/instrumented_libraries/install-build-deps.sh File third_party/instrumented_libraries/install-build-deps.sh (right): https://codereview.chromium.org/952173002/diff/1/third_party/instrumented_libraries/install-build-deps.sh#newcode88 third_party/instrumented_libraries/install-build-deps.sh:88: sudo apt-get build-dep -y $packages OOC, why have ...
5 years, 9 months ago (2015-03-10 09:59:05 UTC) #6
earthdok
5 years, 9 months ago (2015-03-10 14:05:27 UTC) #7
Message was sent while issue was closed. 
On 2015/03/10 09:59:05, Alexander Potapenko wrote:
> LGTM
> 
>
https://codereview.chromium.org/952173002/diff/1/third_party/instrumented_lib...
> File third_party/instrumented_libraries/install-build-deps.sh (right):
> 
>
https://codereview.chromium.org/952173002/diff/1/third_party/instrumented_lib...
> third_party/instrumented_libraries/install-build-deps.sh:88: sudo apt-get
> build-dep -y $packages
> OOC, why have you put this command after the previous one?

apt-get build-dep will fail if jack2 is installed, so we have to replace it with
jack1 (libjack0) before running apt-get build-dep

Powered by Google App Engine
This is Rietveld 408576698