Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 952163002: Fix dependencies on //components/policy in gn files (Closed)

Created:
5 years, 10 months ago by Tomasz Moniuszko
Modified:
5 years, 9 months ago
Reviewers:
brettw, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dependencies on //components/policy in gn files BUG= Committed: https://crrev.com/fe85385d68ca39e48ee37dd7fe952c17b2440b6f Cr-Commit-Position: refs/heads/master@{#318246}

Patch Set 1 #

Patch Set 2 : Missing import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M components/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/ownership/BUILD.gn View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Tomasz Moniuszko
5 years, 10 months ago (2015-02-25 10:46:44 UTC) #2
brettw
lgtm
5 years, 9 months ago (2015-02-25 16:41:21 UTC) #3
sdefresne
lgtm
5 years, 9 months ago (2015-02-25 16:41:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952163002/1
5 years, 9 months ago (2015-02-26 08:27:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/46831)
5 years, 9 months ago (2015-02-26 08:41:42 UTC) #8
Tomasz Moniuszko
I can't explain how I forgot to add this import in previous patch set.
5 years, 9 months ago (2015-02-26 15:34:25 UTC) #9
sdefresne
lgtm
5 years, 9 months ago (2015-02-26 15:40:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952163002/20001
5 years, 9 months ago (2015-02-26 15:49:48 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 16:22:10 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 16:23:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe85385d68ca39e48ee37dd7fe952c17b2440b6f
Cr-Commit-Position: refs/heads/master@{#318246}

Powered by Google App Engine
This is Rietveld 408576698