Issue 952103002: Use Widget::InitParams::shadow_type instead of calling wm::SetShadowType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 952103002: Use Widget::InitParams::shadow_type instead of calling wm::SetShadowType. (Closed)

Created:
5 years, 9 months ago by jackhou1

Modified:
5 years, 9 months ago

Reviewers:
tapted

CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Use Widget::InitParams::shadow_type instead of calling wm::SetShadowType. BUG=459877 Committed: https://crrev.com/a5f60ebc1a68cc85cddda329357048ace079dd70 Cr-Commit-Position: refs/heads/master@{#317973}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	chrome/browser/ui/views/apps/chrome_native_app_window_views.cc	View		3 chunks	+9 lines, -11 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952103002/1

5 years, 9 months ago (2015-02-25 03:53:38 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-02-25 04:57:38 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a5f60ebc1a68cc85cddda329357048ace079dd70
Cr-Commit-Position: refs/heads/master@{#317973}