Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 952083002: Move ownership of SigninNotificationController upstream. (Closed)

Created:
5 years, 10 months ago by maxbogue
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ownership of SigninNotificationController upstream. Previously owned by GSM downstream. Note that there will be two SigninNotificationControllers in existence between this landing and the downstream patch landing, but the only call its listener makes (cancelNotification) appears to be idempotent so it shouldn't matter. BUG=428882 Committed: https://crrev.com/5ef8fe826e1347681923b959b596751028b75d2a Cr-Commit-Position: refs/heads/master@{#319091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
maxbogue
PTAL, thanks!
5 years, 10 months ago (2015-02-26 22:49:46 UTC) #2
maxbogue
Bump; this is a small change and should not require much time to review.
5 years, 9 months ago (2015-03-02 18:18:57 UTC) #3
nyquist
lgtm
5 years, 9 months ago (2015-03-04 09:16:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952083002/1
5 years, 9 months ago (2015-03-04 18:22:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 18:53:51 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 18:55:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ef8fe826e1347681923b959b596751028b75d2a
Cr-Commit-Position: refs/heads/master@{#319091}

Powered by Google App Engine
This is Rietveld 408576698