Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 952063002: [NaCL SDK] Add pepper_42 to naclsdk_manifest2.json (Closed)

Created:
5 years, 10 months ago by Sam Clegg
Modified:
5 years, 10 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCL SDK] Add pepper_42 to naclsdk_manifest2.json Also remove oldest SDK version (pepper_34). Committed: https://crrev.com/a1479526e1e90f74a6efb87f842f508823a1332d Cr-Commit-Position: refs/heads/master@{#318069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sam Clegg
5 years, 10 months ago (2015-02-24 23:57:01 UTC) #2
binji
lgtm but before you land this, it would be good to check that there is ...
5 years, 10 months ago (2015-02-25 00:54:54 UTC) #3
Sam Clegg
On 2015/02/25 00:54:54, binji wrote: > lgtm > > but before you land this, it ...
5 years, 10 months ago (2015-02-25 17:29:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952063002/1
5 years, 10 months ago (2015-02-25 17:29:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 17:32:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 17:33:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1479526e1e90f74a6efb87f842f508823a1332d
Cr-Commit-Position: refs/heads/master@{#318069}

Powered by Google App Engine
This is Rietveld 408576698