Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 952053004: Fix 'gn clean'. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'gn clean'. The new 'gn clean' command didn't actually work right; when we read in the existing build.ninja file, we would trim the leading whitespace from the lines, producing an invalide ninja file as a result. R=brettw@chromium.org BUG= Committed: https://crrev.com/5c1a294cd30d44560ce45980a809f86146584761 Cr-Commit-Position: refs/heads/master@{#318189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/command_clean.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-24 23:58:28 UTC) #1
brettw
lgtm
5 years, 10 months ago (2015-02-24 23:59:34 UTC) #2
tfarina
lgtm
5 years, 10 months ago (2015-02-25 00:04:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952053004/1
5 years, 10 months ago (2015-02-26 03:29:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 05:07:44 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 05:08:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c1a294cd30d44560ce45980a809f86146584761
Cr-Commit-Position: refs/heads/master@{#318189}

Powered by Google App Engine
This is Rietveld 408576698