Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 952053003: extensions: allow trash to have a focus outline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extensions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 6083af00dab721f0be646524f37501d0e7fdf0bd..8adecc49c9ee2691c2e7aee050bf09090980ac14 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -65,7 +65,7 @@
*/
var ExtensionData;
-cr.define('options', function() {
Dan Beam 2015/02/24 23:32:43 no idea why this was in options.*
+cr.define('extensions', function() {
'use strict';
/**
@@ -74,7 +74,7 @@ cr.define('options', function() {
* @constructor
* @extends {HTMLDivElement}
*/
- var ExtensionsList = cr.ui.define('div');
Dan Beam 2015/02/24 23:32:43 changed to match file name (extension_list.js)
+ var ExtensionList = cr.ui.define('div');
/**
* @type {Object<string, number>} A map from extension id to last reloaded
@@ -84,7 +84,7 @@ cr.define('options', function() {
*/
var extensionReloadedTimestamp = {};
- ExtensionsList.prototype = {
+ ExtensionList.prototype = {
__proto__: HTMLDivElement.prototype,
/**
@@ -286,6 +286,7 @@ cr.define('options', function() {
var trash = trashTemplate.cloneNode(true);
trash.title = loadTimeData.getString('extensionUninstall');
trash.addEventListener('click', function(e) {
+ trash.classList.add('open');
chrome.send('extensionSettingsUninstall', [extension.id]);
});
node.querySelector('.enable-controls').appendChild(trash);
@@ -701,7 +702,11 @@ cr.define('options', function() {
},
};
+ ExtensionList.uninstallCancel = function() {
+ document.querySelector('.trash.open').classList.remove('open');
+ };
+
return {
- ExtensionsList: ExtensionsList
+ ExtensionList: ExtensionList
};
});
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extensions.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698