extensions: allow trash to have a focus outline.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 /**
  * The type of the extension data object. The definition is based on
  * chrome/browser/ui/webui/extensions/extension_basic_info.cc
  * and
@@ skipping 47 matching lines @@
  *            version: string,
  *            views: Array<{renderViewId: number, renderProcessId: number,
  *                path: string, incognito: boolean,
  *                generatedBackgroundPage: boolean}>,
  *            wantsErrorCollection: boolean,
  *            wantsFileAccess: boolean,
  *            warnings: (Array|undefined)}}
  */
 var ExtensionData;
 
-cr.define('options', function() {
+cr.define('extensions', function() {
   'use strict';
 
   /**
    * Creates a new list of extensions.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
    * @extends {HTMLDivElement}
    */
-  var ExtensionsList = cr.ui.define('div');
+  var ExtensionList = cr.ui.define('div');
 
   /**
    * @type {Object<string, number>} A map from extension id to last reloaded
    *     timestamp. The timestamp is recorded when the user click the 'Reload'
    *     link. It is used to refresh the icon of an unpacked extension.
    *     This persists between calls to decorate.
    */
   var extensionReloadedTimestamp = {};
 
-  ExtensionsList.prototype = {
+  ExtensionList.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     /**
      * Indicates whether an embedded options page that was navigated to through
      * the '?options=' URL query has been shown to the user. This is necessary
      * to prevent showExtensionNodes_ from opening the options more than once.
      * @type {boolean}
      * @private
      */
     optionsShown_: false,
@@ skipping 181 matching lines @@
         // disabled, because the user might e.g. get prompted when enabling
         // and choose not to.
         e.preventDefault();
       });
 
       // 'Remove' button.
       var trashTemplate = $('template-collection').querySelector('.trash');
       var trash = trashTemplate.cloneNode(true);
       trash.title = loadTimeData.getString('extensionUninstall');
       trash.addEventListener('click', function(e) {
+        trash.classList.add('open');
+        trash.classList.toggle('mouse-clicked', e.detail > 0);
         chrome.send('extensionSettingsUninstall', [extension.id]);
       });
       node.querySelector('.enable-controls').appendChild(trash);
 
       // Developer mode ////////////////////////////////////////////////////////
 
       // The path, if provided by unpacked extension.
       this.addListener_('click', node, '.load-path a:first-of-type',
                         function(e) {
         chrome.send('extensionSettingsShowPath', [String(extension.id)]);
@@ skipping 395 matching lines @@
         self.optionsShown_ = false;
         $('overlay').removeEventListener('cancelOverlay', f);
       });
 
       // TODO(dbeam): why do we need to focus <extensionoptions> before and
       // after its showing animation? Makes very little sense to me.
       overlay.setInitialFocus();
     },
   };
 
+  ExtensionList.uninstallCancel = function() {
+    var trash = document.querySelector('.trash.open');
+    if (trash.classList.contains('mouse-clicked'))

[Evan Stade, 2015/02/26 02:49:19]

seems like this can crash if .trash.open is not found (due to a race for
example?)

[Dan Beam, 2015/02/26 03:02:42]

i think that'd be unexpected and therefore should "crash".  didn't add an assert
because the code will do the same thing (throw) with an NPE right after.

+      trash.blur();
+    trash.classList.remove('open');
+  };
+
   return {
-    ExtensionsList: ExtensionsList
+    ExtensionList: ExtensionList
   };
 });