extensions: allow trash to have a focus outline.

extensions: allow trash to have a focus outline.

This makes more sense when it's an inline element in the page,
accessible by keyboard or mouse focus.

On chrome://apps it's not possible to focus this element
as far as I know; it's only shown while dragging.

R=estade@chromium.org
BUG=456706
TEST=visual, see bug

Committed: https://crrev.com/0517b0405b9b45882ba6a852ac0e5d49bd2fedcf
Cr-Commit-Position: refs/heads/master@{#318200}

[Dan Beam, 2015-02-24 23:32:43]

http://imgur.com/a/vVR5r

https://codereview.chromium.org/952053003/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extension_list.js (left):

https://codereview.chromium.org/952053003/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extension_list.js:68: cr.define('options',
function() {
no idea why this was in options.*

https://codereview.chromium.org/952053003/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extension_list.js:77: var ExtensionsList =
cr.ui.define('div');
changed to match file name (extension_list.js)

[Dan Beam, 2015-02-26 00:35:18]

ping

[Dan Beam, 2015-02-26 01:49:48]

updated to just blur() when clicked

[Evan Stade, 2015-02-26 02:49:19]

https://codereview.chromium.org/952053003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/952053003/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_list.js:708: if
(trash.classList.contains('mouse-clicked'))
seems like this can crash if .trash.open is not found (due to a race for
example?)

[Dan Beam, 2015-02-26 03:02:42]

https://codereview.chromium.org/952053003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/952053003/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_list.js:708: if
(trash.classList.contains('mouse-clicked'))
On 2015/02/26 02:49:19, Evan Stade wrote:
> seems like this can crash if .trash.open is not found (due to a race for
> example?)

i think that'd be unexpected and therefore should "crash".  didn't add an assert
because the code will do the same thing (throw) with an NPE right after.

[Evan Stade, 2015-02-26 03:02:42]

lgtm

[Dan Beam, 2015-02-26 03:04:22]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-02-26 03:06:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952053003/20001

[commit-bot: I haz the power, 2015-02-26 03:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-26 03:11:40]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[Dan Beam, 2015-02-26 04:40:44]

Patchset #3 (id:40001) has been deleted

[Dan Beam, 2015-02-26 04:41:10]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2015-02-26 04:41:10]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/952053003/#ps60001 (title:
"merge")

[commit-bot: I haz the power, 2015-02-26 04:42:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952053003/60001

[commit-bot: I haz the power, 2015-02-26 06:41:59]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-02-26 06:42:48]

Patchset 3 (id:??) landed as
https://crrev.com/0517b0405b9b45882ba6a852ac0e5d49bd2fedcf
Cr-Commit-Position: refs/heads/master@{#318200}