Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 95203005: MIPS: Fix failures on Octane 2.0 zlib benchmark. (Closed)

Created:
7 years ago by dusmil
Modified:
7 years ago
Reviewers:
kisg, Paul Lind, palfia, kilvadyb
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix failures on Octane 2.0 zlib benchmark. The bug was introduced in af9504e. The zlib benchmark triggers long branch mode on MIPS, in which at register is clobbered after every branch. TEST=benchmarks/octane/zlib BUG= Committed: https://code.google.com/p/v8/source/detail?r=18168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dusmil
7 years ago (2013-11-29 19:54:06 UTC) #1
palfia
Very good catch, thank you! Looks good to me.
7 years ago (2013-11-29 20:05:54 UTC) #2
Paul Lind
LGTM, thanks Dusan.
7 years ago (2013-11-29 23:08:08 UTC) #3
palfia
I'll land this CL.
7 years ago (2013-11-29 23:39:27 UTC) #4
palfia
7 years ago (2013-11-29 23:46:39 UTC) #5
Committed as r18168.

Powered by Google App Engine
This is Rietveld 408576698