Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3437)

Unified Diff: chrome/browser/ui/views/passwords/manage_credential_item_view.cc

Issue 952023002: Credential Manager API: pop up the new "Manage accounts" bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_credential_item_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_credential_item_view.cc b/chrome/browser/ui/views/passwords/manage_credential_item_view.cc
index d880316b62dc3d3a5b0d1729458a08a044ca8754..11ffca4f4a1a74fb989c635d21117a558b71dd5d 100644
--- a/chrome/browser/ui/views/passwords/manage_credential_item_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_credential_item_view.cc
@@ -8,6 +8,7 @@
#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
#include "chrome/browser/ui/views/passwords/credentials_item_view.h"
#include "chrome/grit/generated_resources.h"
+#include "components/autofill/core/common/password_form.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/resources/grit/ui_resources.h"
@@ -49,7 +50,7 @@ void BuildColumnSet(views::GridLayout* layout) {
ManageCredentialItemView::ManageCredentialItemView(
ManagePasswordsBubbleModel* model,
const autofill::PasswordForm* password_form)
- : form_(*password_form),
+ : form_(password_form),
delete_button_(nullptr),
undo_link_(nullptr),
model_(model),
@@ -57,7 +58,7 @@ ManageCredentialItemView::ManageCredentialItemView(
net::URLRequestContextGetter* request_context =
model_->GetProfile()->GetRequestContext();
credential_button_.reset(new CredentialsItemView(
- this, &form_, password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL,
+ this, form_, password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL,
CredentialsItemView::ACCOUNT_CHOOSER, request_context));
credential_button_->set_owned_by_client();
credential_button_->SetEnabled(false);
@@ -108,7 +109,7 @@ void ManageCredentialItemView::ButtonPressed(views::Button* sender,
const ui::Event& event) {
DCHECK_EQ(delete_button_, sender);
form_deleted_ = true;
- // TODO(vasilii): notify |model_| about the deletion.
+ model_->OnPasswordAction(*form_, ManagePasswordsBubbleModel::REMOVE_PASSWORD);
Refresh();
}
@@ -116,6 +117,6 @@ void ManageCredentialItemView::LinkClicked(views::Link* source,
int event_flags) {
DCHECK_EQ(undo_link_, source);
form_deleted_ = false;
- // TODO(vasilii): notify |model_| about adding.
+ model_->OnPasswordAction(*form_, ManagePasswordsBubbleModel::ADD_PASSWORD);
Refresh();
}

Powered by Google App Engine
This is Rietveld 408576698