Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4225)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 952023002: Credential Manager API: pop up the new "Manage accounts" bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
index 30be83e7ee376a56d60124547467d36f893da93d..f5511fd17e384f81a53a1fdcc889730b71dee86c 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
@@ -517,9 +517,27 @@ TEST_F(ManagePasswordsUIControllerTest, AutoSignin) {
EXPECT_EQ(password_manager::ui::AUTO_SIGNIN_STATE, mock.state());
controller()->OnBubbleHidden();
- EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->state());
+ EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->state());
controller()->UpdateIconAndBubbleState(&mock);
- EXPECT_EQ(password_manager::ui::INACTIVE_STATE, mock.state());
+ EXPECT_EQ(password_manager::ui::MANAGE_STATE, mock.state());
+}
+
+TEST_F(ManagePasswordsUIControllerTest, AutoSigninClickThrough) {
+ ScopedVector<autofill::PasswordForm> local_credentials;
+ local_credentials.push_back(new autofill::PasswordForm(test_local_form()));
+ controller()->OnAutoSignin(local_credentials.Pass());
+ EXPECT_EQ(password_manager::ui::AUTO_SIGNIN_STATE, controller()->state());
+ EXPECT_EQ(test_local_form().origin, controller()->origin());
+ ASSERT_FALSE(controller()->GetCurrentForms().empty());
+ EXPECT_EQ(test_local_form(), *controller()->GetCurrentForms()[0]);
+ ManagePasswordsIconMock mock;
+ controller()->UpdateIconAndBubbleState(&mock);
+ EXPECT_EQ(password_manager::ui::AUTO_SIGNIN_STATE, mock.state());
+
+ controller()->ManageAccounts();
+ EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->state());
+ controller()->UpdateIconAndBubbleState(&mock);
+ EXPECT_EQ(password_manager::ui::MANAGE_STATE, mock.state());
}
TEST_F(ManagePasswordsUIControllerTest, InactiveOnPSLMatched) {

Powered by Google App Engine
This is Rietveld 408576698