Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2776)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 952023002: Credential Manager API: pop up the new "Manage accounts" bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge with the trunk Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
index d8e550d12cc6cc2b8998f77fb142209e4bbfd86c..7058b77faa7a77d04d1f4b9113b275630667bef4 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
@@ -7,6 +7,7 @@
#include "base/metrics/histogram_samples.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/passwords/manage_passwords_test.h"
+#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
@@ -314,4 +315,17 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSignin) {
SetupAutoSignin(local_credentials.Pass());
EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());
+ ::testing::Mock::VerifyAndClearExpectations(&url_callback);
+
+ ManagePasswordsBubbleView::CloseBubble();
+ EXPECT_FALSE(ManagePasswordsBubbleView::IsShowing());
+ content::RunAllPendingInMessageLoop();
+
+ // Open the bubble to manage accounts.
+ EXPECT_EQ(password_manager::ui::MANAGE_STATE, GetController()->state());
+ EXPECT_CALL(url_callback, OnRequestDone(avatar_url));
Mike West 2015/03/18 08:33:51 This expectation is failing. Perhaps you need to p
vasilii 2015/03/18 09:25:09 No, we were opening the old UI without avatars.
+ ManagePasswordsBubbleView::ShowBubble(
+ browser()->tab_strip_model()->GetActiveWebContents(),
+ ManagePasswordsBubble::USER_ACTION);
+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());
}

Powered by Google App Engine
This is Rietveld 408576698