Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/autofill/core/common/password_form.h

Issue 952023002: Credential Manager API: pop up the new "Manage accounts" bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index 783eda54786c8e433d20807d7799e65c5523b62b..31e3ed05352bb0021b76182b27d8631270e647f9 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -254,6 +254,11 @@ typedef std::map<base::string16, PasswordForm*> PasswordFormMap;
typedef std::map<base::string16, const PasswordForm*> ConstPasswordFormMap;
+// True if the unique key for the forms is the same. The unique key is
Ilya Sherman 2015/02/24 21:45:48 nit: "key for the forms is the same" -> "keys for
vasilii 2015/02/25 09:39:50 Done.
+// (origin, username_element, username_value, password_element, signon_realm).
+// It's used by Sync and LoginDatabase.
Ilya Sherman 2015/02/24 21:45:48 I don't see these uses in the diff. In fact, I on
vasilii 2015/02/25 09:39:50 I move this function temporarily out of here. It w
+bool IsEqualUniqueKey(const PasswordForm& left, const PasswordForm& right);
+
// For testing.
std::ostream& operator<<(std::ostream& os,
const autofill::PasswordForm& form);

Powered by Google App Engine
This is Rietveld 408576698