Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 951983003: Updated gypi file after skia header moved. (Closed)

Created:
5 years, 10 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
Reviewers:
Stephen White
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated gypi file after skia header moved. At some time skia/include/ports/SkFontStyle.h moved to skia/include/core and the gypi file wasn't updated when that skia version was imported. R=senorblanco@chromium.org BUG=459058 Committed: https://crrev.com/20952e3f75c6f20d73218e1dff5bff446f88a6ed Cr-Commit-Position: refs/heads/master@{#317845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M skia/skia_library.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Daniel Bratell
5 years, 10 months ago (2015-02-24 16:22:19 UTC) #1
Stephen White
LGTM
5 years, 10 months ago (2015-02-24 16:38:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951983003/1
5 years, 10 months ago (2015-02-24 17:32:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 18:58:44 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 18:59:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20952e3f75c6f20d73218e1dff5bff446f88a6ed
Cr-Commit-Position: refs/heads/master@{#317845}

Powered by Google App Engine
This is Rietveld 408576698