Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 951953003: Reenable FontRenderParamsTest.Default under Valgrind. (Closed)

Created:
5 years, 10 months ago by Daniel Erat
Modified:
5 years, 10 months ago
CC:
chromium-reviews, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable FontRenderParamsTest.Default under Valgrind. ui/gfx/ no longer depends on Pango, which was seemingly causing issues with Fontconfig finalization. BUG=402209 Committed: https://crrev.com/c4a91a2410df295273464f2ec97d0c4f89c8d3f2 Cr-Commit-Position: refs/heads/master@{#318334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
D tools/valgrind/gtest_exclude/gfx_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Daniel Erat
i don't see any bots that i can use to verify this, but i *think* ...
5 years, 10 months ago (2015-02-24 17:12:59 UTC) #2
Daniel Erat
5 years, 10 months ago (2015-02-26 17:32:45 UTC) #4
Lei Zhang
lgtm, let's see what happens.
5 years, 10 months ago (2015-02-26 21:52:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951953003/1
5 years, 10 months ago (2015-02-26 22:03:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 22:51:04 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 22:54:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4a91a2410df295273464f2ec97d0c4f89c8d3f2
Cr-Commit-Position: refs/heads/master@{#318334}

Powered by Google App Engine
This is Rietveld 408576698