Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 951953002: [DevTools] Check request_id in DevToolsUIBindings::IndexPath (Closed)

Created:
5 years, 10 months ago by vkuzkokov
Modified:
5 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, aandrey+blink_chromium.org, vsevik, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Check request_id in DevToolsUIBindings::IndexPath If request_id is reused before the previous job with the same id is finished the old job won't be stopped in ~DevToolsUIBindings. BUG= Committed: https://crrev.com/88ac3ce8fa6463e5f04d4b3e7e2327e2ec1b3a19 Cr-Commit-Position: refs/heads/master@{#317799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vkuzkokov
5 years, 10 months ago (2015-02-24 14:26:47 UTC) #2
dgozman
lgtm
5 years, 10 months ago (2015-02-24 14:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951953002/1
5 years, 10 months ago (2015-02-24 14:33:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 15:22:44 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/88ac3ce8fa6463e5f04d4b3e7e2327e2ec1b3a19 Cr-Commit-Position: refs/heads/master@{#317799}
5 years, 10 months ago (2015-02-24 15:23:19 UTC) #7
phoglund_chromium
5 years, 10 months ago (2015-02-25 10:19:36 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/956873002/ by phoglund@chromium.org.

The reason for reverting is: Speculative revert:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4683...
became very flaky on Mac OS X 10.6 about when this patch was introduced. This is
the only devtools change near to the start of the flakiness.

The errors are:
DevToolsSanityTest.TestReattachAfterCrash (run #1):
[ RUN      ] DevToolsSanityTest.TestReattachAfterCrash
[32422:28675:0224/105826:WARNING:data_reduction_proxy_config.cc(211)] SPDY proxy
OFF at startup
HTTP server started on http://127.0.0.1:64960...
sending server_data: {"host": "127.0.0.1", "port": 64960} (36 bytes)
[32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack
remove remote endpoint (local ID 1, remote ID 1)
[32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack
remove remote endpoint (local ID 2147483648, remote ID 2.

Powered by Google App Engine
This is Rietveld 408576698