Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: src/hydrogen-load-elimination.cc

Issue 95193002: Fix load elimination: can only .Equals() GVN-able instructions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Don't enable load elimination; do in other CL Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/load-elimination-params.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-load-elimination.cc
diff --git a/src/hydrogen-load-elimination.cc b/src/hydrogen-load-elimination.cc
index f37de90ff3d37311d0d3d4fa6916967bed036b87..f3b574847f8e3ed6b9e5807fa0cee894b18af41b 100644
--- a/src/hydrogen-load-elimination.cc
+++ b/src/hydrogen-load-elimination.cc
@@ -349,7 +349,9 @@ class HLoadEliminationTable : public ZoneObject {
bool Equal(HValue* a, HValue* b) {
if (a == b) return true;
- if (a != NULL && b != NULL) return a->Equals(b);
+ if (a != NULL && b != NULL && a->CheckFlag(HValue::kUseGVN)) {
+ return a->Equals(b);
+ }
return false;
}
« no previous file with comments | « no previous file | test/mjsunit/compiler/load-elimination-params.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698