Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 95193002: Fix load elimination: can only .Equals() GVN-able instructions. (Closed)

Created:
7 years ago by titzer
Modified:
7 years ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix load elimination: can only .Equals() GVN-able instructions. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18133

Patch Set 1 #

Patch Set 2 : Don't enable load elimination; do in other CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M src/hydrogen-load-elimination.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/load-elimination-params.js View 1 chunk +33 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
7 years ago (2013-11-28 14:56:24 UTC) #1
Yang
On 2013/11/28 14:56:24, titzer wrote: LGTM.
7 years ago (2013-11-28 15:00:11 UTC) #2
titzer
7 years ago (2013-11-28 15:27:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698