Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 951903003: [turbofan] Strength reduction for inline comparisons. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Strength reduction for inline comparisons. Perform strength reduction on machine operators with inline comparisons: CMP & 1 => CMP 1 & CMP => CMP CMP << 31 >> 31 => CMP Also strength reduce the following constructs: x + (0 - y) => x - y (0 - y) + x => x - y R=dcarney@chromium.org Committed: https://crrev.com/dcf193f18cb76e60bf3fb978093eed93442d0430 Cr-Commit-Position: refs/heads/master@{#26817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -127 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 3 chunks +58 lines, -23 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/node-matchers.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +117 lines, -104 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 4 chunks +82 lines, -0 lines 0 comments Download
M test/unittests/compiler/opcodes-unittest.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-24 12:02:56 UTC) #1
dcarney
lgtm
5 years, 10 months ago (2015-02-24 12:05:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951903003/1
5 years, 10 months ago (2015-02-24 12:05:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 12:26:23 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 12:26:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcf193f18cb76e60bf3fb978093eed93442d0430
Cr-Commit-Position: refs/heads/master@{#26817}

Powered by Google App Engine
This is Rietveld 408576698