Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 951893002: Revert "Cut down /crypto and switch what is left of it to boringssl." (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
jamesr, blundell
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Cut down /crypto and switch what is left of it to boringssl." This reverts commit 1722df1e3c68f256a8008df925b1c6bdde40be60. It seems to break mojo_shell pulling mojo apps from the web: Command: ./out/Debug/mojo_shell --origin=https://storage.googleapis.com/mojo/services/linux-x64/1722df1e3c68f256a8008df925b1c6bdde40be60 mojo:sample_app Result: [ERROR:native_application_loader.cc(429)] Error (-360: net::ERR_SPDY_INADEQUATE_TRANSPORT_SECURITY) while fetching https://storage.googleapis.com/mojo/services/linux-x64/1722df1e3c68f256a8008df925b1c6bdde40be60/tracing.mojo [ERROR:native_application_loader.cc(429)] Error (-360: net::ERR_SPDY_INADEQUATE_TRANSPORT_SECURITY) while fetching https://storage.googleapis.com/mojo/services/linux-x64/1722df1e3c68f256a8008df925b1c6bdde40be60/sample_app.mojo Do we have a runtime dependency on crypto in network_service.mojo? BUG=456130 R=blundell@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ab0e8ad00f2c279eef7780cd6b17c8826b08e84d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18822 lines, -63 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/BUILD.gn View 2 chunks +266 lines, -1 line 0 comments Download
A + crypto/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
A crypto/apple_keychain.h View 1 chunk +108 lines, -0 lines 0 comments Download
A crypto/apple_keychain_ios.mm View 1 chunk +196 lines, -0 lines 0 comments Download
A crypto/apple_keychain_mac.mm View 1 chunk +144 lines, -0 lines 0 comments Download
A crypto/capi_util.h View 1 chunk +39 lines, -0 lines 0 comments Download
A crypto/capi_util.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A crypto/crypto.gyp View 1 chunk +318 lines, -0 lines 0 comments Download
A crypto/crypto.gypi View 1 chunk +105 lines, -0 lines 0 comments Download
A + crypto/crypto_nacl.gyp View 1 chunk +16 lines, -13 lines 0 comments Download
A crypto/cssm_init.h View 1 chunk +60 lines, -0 lines 0 comments Download
A crypto/cssm_init.cc View 1 chunk +204 lines, -0 lines 0 comments Download
A crypto/curve25519.h View 1 chunk +48 lines, -0 lines 0 comments Download
A crypto/curve25519.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A crypto/curve25519-donna.c View 1 chunk +592 lines, -0 lines 0 comments Download
A crypto/curve25519_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A crypto/ec_private_key.h View 1 chunk +157 lines, -0 lines 0 comments Download
A crypto/ec_private_key_nss.cc View 1 chunk +405 lines, -0 lines 0 comments Download
A crypto/ec_private_key_openssl.cc View 1 chunk +231 lines, -0 lines 0 comments Download
A crypto/ec_private_key_unittest.cc View 1 chunk +296 lines, -0 lines 0 comments Download
A crypto/ec_signature_creator.h View 1 chunk +66 lines, -0 lines 0 comments Download
A crypto/ec_signature_creator.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A crypto/ec_signature_creator_impl.h View 1 chunk +34 lines, -0 lines 0 comments Download
A crypto/ec_signature_creator_nss.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A crypto/ec_signature_creator_openssl.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A crypto/ec_signature_creator_unittest.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A crypto/encryptor.h View 1 chunk +138 lines, -0 lines 0 comments Download
A crypto/encryptor.cc View 1 chunk +97 lines, -0 lines 0 comments Download
A crypto/encryptor_nss.cc View 1 chunk +202 lines, -0 lines 0 comments Download
A crypto/encryptor_openssl.cc View 1 chunk +176 lines, -0 lines 0 comments Download
A crypto/encryptor_unittest.cc View 1 chunk +531 lines, -0 lines 0 comments Download
A crypto/ghash.h View 1 chunk +86 lines, -0 lines 0 comments Download
A crypto/ghash.cc View 1 chunk +259 lines, -0 lines 0 comments Download
A crypto/ghash_unittest.cc View 1 chunk +148 lines, -0 lines 0 comments Download
A crypto/hkdf.h View 1 chunk +71 lines, -0 lines 0 comments Download
A crypto/hkdf.cc View 1 chunk +107 lines, -0 lines 0 comments Download
A crypto/hkdf_unittest.cc View 1 chunk +94 lines, -0 lines 0 comments Download
A crypto/hmac.h View 1 chunk +93 lines, -0 lines 0 comments Download
A crypto/hmac.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A crypto/hmac_nss.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A crypto/hmac_openssl.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A crypto/hmac_unittest.cc View 1 chunk +295 lines, -0 lines 0 comments Download
A crypto/hmac_win.cc View 1 chunk +209 lines, -0 lines 0 comments Download
A crypto/mac_security_services_lock.h View 1 chunk +25 lines, -0 lines 0 comments Download
A crypto/mac_security_services_lock.cc View 1 chunk +42 lines, -0 lines 0 comments Download
A crypto/mock_apple_keychain.h View 1 chunk +250 lines, -0 lines 0 comments Download
A crypto/mock_apple_keychain.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A crypto/mock_apple_keychain_ios.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A crypto/mock_apple_keychain_mac.cc View 1 chunk +509 lines, -0 lines 0 comments Download
A crypto/nss_crypto_module_delegate.h View 1 chunk +53 lines, -0 lines 0 comments Download
A crypto/nss_util.h View 1 chunk +155 lines, -0 lines 0 comments Download
A crypto/nss_util.cc View 1 chunk +1105 lines, -0 lines 0 comments Download
A crypto/nss_util_internal.h View 1 chunk +113 lines, -0 lines 0 comments Download
A crypto/nss_util_unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A crypto/openssl_bio_string.h View 1 chunk +29 lines, -0 lines 0 comments Download
A crypto/openssl_bio_string.cc View 1 chunk +77 lines, -0 lines 0 comments Download
A crypto/openssl_bio_string_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A crypto/p224.h View 1 chunk +60 lines, -0 lines 0 comments Download
A crypto/p224.cc View 1 chunk +758 lines, -0 lines 0 comments Download
A crypto/p224_spake.h View 1 chunk +126 lines, -0 lines 0 comments Download
A crypto/p224_spake.cc View 1 chunk +268 lines, -0 lines 0 comments Download
A crypto/p224_spake_unittest.cc View 1 chunk +174 lines, -0 lines 0 comments Download
A crypto/p224_unittest.cc View 1 chunk +824 lines, -0 lines 0 comments Download
A crypto/rsa_private_key.h View 1 chunk +293 lines, -0 lines 0 comments Download
A crypto/rsa_private_key.cc View 1 chunk +384 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_nss.cc View 1 chunk +332 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_nss_unittest.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_openssl.cc View 1 chunk +138 lines, -0 lines 0 comments Download
A crypto/rsa_private_key_unittest.cc View 1 chunk +473 lines, -0 lines 0 comments Download
A crypto/scoped_capi_types.h View 1 chunk +121 lines, -0 lines 0 comments Download
A crypto/scoped_nss_types.h View 1 chunk +61 lines, -0 lines 0 comments Download
A crypto/scoped_test_nss_chromeos_user.h View 1 chunk +43 lines, -0 lines 0 comments Download
A crypto/scoped_test_nss_chromeos_user.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A crypto/scoped_test_nss_db.h View 1 chunk +35 lines, -0 lines 0 comments Download
A crypto/scoped_test_nss_db.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A crypto/scoped_test_system_nss_key_slot.h View 1 chunk +43 lines, -0 lines 0 comments Download
A crypto/scoped_test_system_nss_key_slot.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A + crypto/secure_hash_default.cc View 3 chunks +14 lines, -22 lines 0 comments Download
A crypto/secure_util.h View 1 chunk +29 lines, -0 lines 0 comments Download
A crypto/secure_util.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A crypto/signature_creator.h View 1 chunk +73 lines, -0 lines 0 comments Download
A crypto/signature_creator_nss.cc View 1 chunk +118 lines, -0 lines 0 comments Download
A crypto/signature_creator_openssl.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A crypto/signature_creator_unittest.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A crypto/signature_verifier.h View 1 chunk +145 lines, -0 lines 0 comments Download
A crypto/signature_verifier_nss.cc View 1 chunk +226 lines, -0 lines 0 comments Download
A crypto/signature_verifier_openssl.cc View 1 chunk +160 lines, -0 lines 0 comments Download
A crypto/signature_verifier_unittest.cc View 1 chunk +1167 lines, -0 lines 0 comments Download
A crypto/symmetric_key.h View 1 chunk +101 lines, -0 lines 0 comments Download
A crypto/symmetric_key_nss.cc View 1 chunk +149 lines, -0 lines 0 comments Download
A crypto/symmetric_key_openssl.cc View 1 chunk +104 lines, -0 lines 0 comments Download
A crypto/symmetric_key_unittest.cc View 1 chunk +225 lines, -0 lines 0 comments Download
A crypto/symmetric_key_win.cc View 1 chunk +536 lines, -0 lines 0 comments Download
A + crypto/third_party/nss/LICENSE View 1 chunk +2 lines, -2 lines 0 comments Download
A crypto/third_party/nss/README.chromium View 1 chunk +18 lines, -0 lines 0 comments Download
A crypto/third_party/nss/chromium-blapi.h View 1 chunk +101 lines, -0 lines 0 comments Download
A crypto/third_party/nss/chromium-blapit.h View 1 chunk +91 lines, -0 lines 0 comments Download
A crypto/third_party/nss/chromium-nss.h View 1 chunk +79 lines, -0 lines 0 comments Download
A + crypto/third_party/nss/chromium-prtypes.h View 2 chunks +40 lines, -10 lines 0 comments Download
A + crypto/third_party/nss/chromium-sha256.h View 2 chunks +14 lines, -10 lines 0 comments Download
A crypto/third_party/nss/pk11akey.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A crypto/third_party/nss/rsawrapr.c View 1 chunk +160 lines, -0 lines 0 comments Download
A crypto/third_party/nss/secsign.cc View 1 chunk +132 lines, -0 lines 0 comments Download
A crypto/third_party/nss/sha512.cc View 1 chunk +1391 lines, -0 lines 0 comments Download
A crypto/wincrypt_shim.h View 1 chunk +25 lines, -0 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ppi
Thanks for catching this, Colin.
5 years, 10 months ago (2015-02-24 11:44:59 UTC) #3
blundell
Rubberstamp LGTM
5 years, 10 months ago (2015-02-24 11:46:32 UTC) #4
ppi
5 years, 10 months ago (2015-02-24 11:48:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab0e8ad00f2c279eef7780cd6b17c8826b08e84d.

Powered by Google App Engine
This is Rietveld 408576698