Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 951883006: Reenable all except for ref build of service_worker_micro_benchmark. (Closed)

Created:
5 years, 10 months ago by horo
Modified:
5 years, 10 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable all except for ref build of service_worker_micro_benchmark. We can't enable on the ref build because SW doesn't work on the current ref build (M37). BUG=442752 Committed: https://crrev.com/ad09c515d419f7c8eb0ebcc526103d84be1a266c Cr-Commit-Position: refs/heads/master@{#317961}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove xp and add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/benchmarks/service_worker.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
horo
sullivan@ Could you review this?
5 years, 10 months ago (2015-02-25 00:02:27 UTC) #2
sullivan
lgtm Please address comment before submitting. https://codereview.chromium.org/951883006/diff/1/tools/perf/benchmarks/service_worker.py File tools/perf/benchmarks/service_worker.py (right): https://codereview.chromium.org/951883006/diff/1/tools/perf/benchmarks/service_worker.py#newcode188 tools/perf/benchmarks/service_worker.py:188: @benchmark.Disabled('reference', 'xp') Can ...
5 years, 10 months ago (2015-02-25 01:47:10 UTC) #3
horo
On 2015/02/25 01:47:10, sullivan wrote: > lgtm > > Please address comment before submitting. > ...
5 years, 10 months ago (2015-02-25 01:59:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951883006/20001
5 years, 10 months ago (2015-02-25 02:01:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 03:09:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 03:09:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad09c515d419f7c8eb0ebcc526103d84be1a266c
Cr-Commit-Position: refs/heads/master@{#317961}

Powered by Google App Engine
This is Rietveld 408576698