Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 951883005: Clean-up NativeBackendLibsecretTest (Closed)

Created:
5 years, 9 months ago by vabr (Chromium)
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean-up NativeBackendLibsecretTest This CL removes CheckPasswordChangesWithResult, because unlike in the other native backend tests, this method was not used inside base::Bind, and so is less useful than confusing. It also removes a global std::vector in favour of replacing it with a pointer to a test-owned instance, and turns that instance into a ScopedVector. BUG=461385 Committed: https://crrev.com/be80bf74e784f8ad15402c7aecf593b384c5c33b Cr-Commit-Position: refs/heads/master@{#318009}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -83 lines) Patch
M chrome/browser/password_manager/native_backend_libsecret_unittest.cc View 29 chunks +75 lines, -83 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vabr (Chromium)
Hi Mike, PTAL at this clean-up. Cheers! Vaclav
5 years, 9 months ago (2015-02-24 17:51:59 UTC) #3
Mike West
LGTM.
5 years, 9 months ago (2015-02-24 18:05:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951883005/20001
5 years, 9 months ago (2015-02-25 08:10:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-02-25 09:44:30 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-25 09:45:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be80bf74e784f8ad15402c7aecf593b384c5c33b
Cr-Commit-Position: refs/heads/master@{#318009}

Powered by Google App Engine
This is Rietveld 408576698