chrome/browser/password_manager/password_store_x.cc - Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x.cc

Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc ('K') | « chrome/browser/password_manager/password_store_win_unittest.cc ('k') | chrome/browser/password_manager/password_store_x_unittest.cc » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_x.cc

diff --git a/chrome/browser/password_manager/password_store_x.cc b/chrome/browser/password_manager/password_store_x.cc

index 5ae4cde964e68efb4af3b48bfdb2fad2b417089f..006fbbd90fa92ed0ac7cd83db944d2da31c9db1a 100644

--- a/chrome/browser/password_manager/password_store_x.cc

+++ b/chrome/browser/password_manager/password_store_x.cc

@@ -239,7 +239,7 @@ void PasswordStoreX::CheckMigration() {

} else {

LOG(WARNING) << "Native password store migration failed! " <<

"Falling back on default (unencrypted) store.";

- backend_.reset(NULL);

+ backend_.reset(nullptr);

vabr (Chromium) 2015/02/24 11:40:14 Just call reset() instead of reset(nullptr). Also

Pritam Nikam 2015/02/24 12:28:51 Done.

}

@@ -247,7 +247,7 @@ bool PasswordStoreX::allow_default_store() {

if (allow_fallback_) {

LOG(WARNING) << "Native password store failed! " <<

"Falling back on default (unencrypted) store.";

- backend_.reset(NULL);

+ backend_.reset(nullptr);

// Don't warn again. We'll use the default store because backend_ is NULL.

allow_fallback_ = false;

}