Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 951783004: Dart: Renames dart:mojo_blah -> mojo:blah (Closed)

Created:
5 years, 10 months ago by zra
Modified:
5 years, 10 months ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Renames dart:mojo_blah -> mojo:blah This improves consistency with the convention that the dart: scheme is only for things from the Dart standard library. BUG= R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8814198f8680f581e90c7630e73d035cd2bee8b4

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -97 lines) Patch
M examples/dart/console_example/main.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/dart/hello_world/hello/main.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/dart/hello_world/world/main.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/dart/wget/main.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/dart/embedder/builtin.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/dart/embedder/builtin.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 6 chunks +32 lines, -11 lines 0 comments Download
M mojo/dart/embedder/mojo_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/test/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/dart/embedder/test/dart_to_cpp_tests.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/embedder/test/test_snapshot.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/dart/test/async_await_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/bindings_generation_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/test/codec_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/test/compile_all_interfaces_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/test/core_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/handle_finalizer_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/dart/test/handle_watcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/import_mojo.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/test/interface_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/test/ping_pong_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/simple_handle_watcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/timer_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/dart/test/validation_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/dart/application.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/dart/bindings.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M services/dart/snapshot.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M services/dart/test/echo/main.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M services/dart/test/pingpong/main.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M services/dart/test/pingpong_target/main.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/bindings/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/builtin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/mojo_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/snapshot.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/script/dart_loader.cc View 2 chunks +9 lines, -1 line 0 comments Download
M sky/examples/dart-mojo.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/embedder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/services/iframe-embed-vmc.sky View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/tests/services/network.sky View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
5 years, 10 months ago (2015-02-24 19:26:30 UTC) #2
Elliot Glaysher
lgtm
5 years, 10 months ago (2015-02-24 20:12:58 UTC) #3
zra
5 years, 10 months ago (2015-02-25 22:29:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8814198f8680f581e90c7630e73d035cd2bee8b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698