Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 951773005: Enables bump scrolling browser test on the Chromoting Waterfall. (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
Reviewers:
anandc, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enables bump scrolling browser test on the Chromoting Waterfall. This CL enables bump scrolling browser test on the Chromoting Waterfall. It also fixes the test logic of retrieving the plugin position for testing. BUG=461538 TEST=New test passed in Chromoting waterfall https://chromium-swarm.appspot.com/user/task/25d71d39de843110 Committed: https://crrev.com/1ef617bbcc2ebfc22415a08aadf6df52eb3a0405 Cr-Commit-Position: refs/heads/master@{#318081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M remoting/webapp/browser_test/bump_scroll_browser_test.js View 4 chunks +22 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/desktop_viewport.js View 1 chunk +10 lines, -3 lines 0 comments Download
M testing/chromoting/browser_test_commands_linux.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
kelvinp
PTAL
5 years, 10 months ago (2015-02-25 01:19:28 UTC) #2
anandc
On 2015/02/25 01:19:28, kelvinp wrote: > PTAL LGTM
5 years, 10 months ago (2015-02-25 04:39:27 UTC) #3
Jamie
lgtm
5 years, 10 months ago (2015-02-25 17:43:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951773005/1
5 years, 10 months ago (2015-02-25 17:47:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 18:43:21 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 18:43:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ef617bbcc2ebfc22415a08aadf6df52eb3a0405
Cr-Commit-Position: refs/heads/master@{#318081}

Powered by Google App Engine
This is Rietveld 408576698