Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 951773002: [Telemetry] Update facebook credential & reenable memory.top_7_stress (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org, petrcermak, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Update facebook credential & re-record the facebook page in top_7_stress & reenable memory.top_7_stress. BUG=459646 TEST=./tools/perf/run_benchmark memory.top_7_stress --browser=system Committed: https://crrev.com/86c9a9b5470c3c1292fc7a8e7e276045ab0f512c Cr-Commit-Position: refs/heads/master@{#317793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/top_7_stress.json View 1 chunk +3 lines, -1 line 0 comments Download
A tools/perf/page_sets/data/top_7_stress_003.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nednguyen
5 years, 10 months ago (2015-02-24 03:16:52 UTC) #2
sullivan
lgtm Thanks for doing this! Note that for some reason this test was only failing ...
5 years, 10 months ago (2015-02-24 14:12:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951773002/1
5 years, 10 months ago (2015-02-24 14:13:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 14:17:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86c9a9b5470c3c1292fc7a8e7e276045ab0f512c Cr-Commit-Position: refs/heads/master@{#317793}
5 years, 10 months ago (2015-02-24 14:17:48 UTC) #7
nednguyen
5 years, 10 months ago (2015-02-24 15:55:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/952963002/ by nednguyen@google.com.

The reason for reverting is: Forgot to upload the wpr archive. Both the
reference build & current one are failing:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/bui....

Powered by Google App Engine
This is Rietveld 408576698