Add enable_media_router defines for GN and gyp.

Add enable_media_router defines for GN and gyp.

BUG=460971
R=scherkus@chromium.org,DaleCurtis@chromium.org,xhwang@chromium.org,mfoltz@chromium.org

Committed: https://crrev.com/87ef387dc7af9492c9605b6ed79ef8abd7eaa8a0
Cr-Commit-Position: refs/heads/master@{#317931}

[DaleCurtis, 2015-02-23 23:34:35]

https://codereview.chromium.org/951713002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/951713002/diff/1/build/common.gypi#newcode2659
build/common.gypi:2659: 'defines': ['ENABLE_MEDIA_ROUTER=1'],
This is unlikely to be approved. The build/ owners are not accepting any new
global defines. You'll need to scope this to the relevant targets.

[Kevin M, 2015-02-24 00:12:15]

https://codereview.chromium.org/951713002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/951713002/diff/1/build/common.gypi#newcode2659
build/common.gypi:2659: 'defines': ['ENABLE_MEDIA_ROUTER=1'],
On 2015/02/23 23:34:35, DaleCurtis wrote:
> This is unlikely to be approved. The build/ owners are not accepting any new
> global defines. You'll need to scope this to the relevant targets.

Done. Made a note of that in our upstreaming plans.

[DaleCurtis, 2015-02-24 00:24:22]

https://codereview.chromium.org/951713002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/951713002/diff/20001/build/common.gypi#newcod...
build/common.gypi:516: 'enable_media_router%': 1,
Do you plan to upstream with this on by default?

[Kevin M, 2015-02-24 01:49:43]

https://codereview.chromium.org/951713002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/951713002/diff/20001/build/common.gypi#newcod...
build/common.gypi:516: 'enable_media_router%': 1,
On 2015/02/24 00:24:22, DaleCurtis wrote:
> Do you plan to upstream with this on by default?

Yes. We'll want it on so that we can benefit from Chromium's continuous
integration and trybots while we upstream.

[wfa511com, 2015-02-24 02:00:47]

بتاريخ Feb 24, 2015 2:34 AM، كتبها <dalecurtis@chromium.org>:

>
> https://codereview.chromium.org/951713002/diff/1/build/common.gypi
> File build/common.gypi (right):
>
> https://codereview.chromium.org/951713002/diff/1/build/
> common.gypi#newcode2659
> build/common.gypi:2659: 'defines': ['ENABLE_MEDIA_ROUTER=1'],
> This is unlikely to be approved. The build/ owners are not accepting any
> new global defines. You'll need to scope this to the relevant targets.
>
> https://codereview.chromium.org/951713002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[wfa511com, 2015-02-24 02:00:47]

بتاريخ Feb 24, 2015 3:12 AM، كتبها <kmarshall@chromium.org>:

>
> https://codereview.chromium.org/951713002/diff/1/build/common.gypi
> File build/common.gypi (right):
>
> https://codereview.chromium.org/951713002/diff/1/build/
> common.gypi#newcode2659
> build/common.gypi:2659: 'defines': ['ENABLE_MEDIA_ROUTER=1'],
> On 2015/02/23 23:34:35, DaleCurtis wrote:
>
>> This is unlikely to be approved. The build/ owners are not accepting
>>
> any new
>
>> global defines. You'll need to scope this to the relevant targets.
>>
>
> Done. Made a note of that in our upstreaming plans.
>
> https://codereview.chromium.org/951713002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[DaleCurtis, 2015-02-24 17:49:18]

lgtm, but you'll need a build/ owner to approve.

[Kevin M, 2015-02-24 18:26:47]

kmarshall@chromium.org changed reviewers:
+ scottmg@chromium.org
- wfa511com@gmail.com

[Kevin M, 2015-02-24 18:26:48]

+scottmg@chromium.org for OWNERS approval

[scottmg, 2015-02-24 18:29:32]

lgtm

[mark a. foltz, 2015-02-24 18:45:56]

lgtm

[Kevin M, 2015-02-24 23:47:10]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2015-02-24 23:47:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951713002/20001

[commit-bot: I haz the power, 2015-02-25 00:46:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-25 00:47:04]

Patchset 2 (id:??) landed as
https://crrev.com/87ef387dc7af9492c9605b6ed79ef8abd7eaa8a0
Cr-Commit-Position: refs/heads/master@{#317931}