Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 951673003: Remove outdated examples and framework pieces (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove outdated examples and framework pieces None of this code runs in the current Sky. Some of it never ran. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1870689dcf4d32b12325966708eecd1a1d76f996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3275 lines) Patch
D sky/examples/animation/basic.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/examples/calculator/buttons.sky View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/examples/dart.sky View 1 chunk +0 lines, -14 lines 0 comments Download
D sky/examples/dart-library.sky View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/examples/file-browser.sky View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/examples/radio.sky View 1 chunk +0 lines, -86 lines 0 comments Download
D sky/framework/inspector/console-agent.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/framework/inspector/css-agent.sky View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/framework/inspector/debug.sky View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/framework/inspector/dom-agent.sky View 1 chunk +0 lines, -173 lines 0 comments Download
D sky/framework/inspector/indexeddb-agent.sky View 1 chunk +0 lines, -14 lines 0 comments Download
D sky/framework/inspector/inspector.sky View 1 chunk +0 lines, -129 lines 0 comments Download
D sky/framework/inspector/page-agent.sky View 1 chunk +0 lines, -108 lines 0 comments Download
D sky/framework/inspector/runtime-agent.sky View 1 chunk +0 lines, -135 lines 0 comments Download
D sky/framework/inspector/worker-agent.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/framework/sky-element/element-registry.sky View 1 chunk +0 lines, -179 lines 0 comments Download
D sky/framework/sky-element/observe.sky View 1 chunk +0 lines, -1361 lines 0 comments Download
D sky/framework/sky-element/sky-binder.sky View 1 chunk +0 lines, -498 lines 0 comments Download
D sky/framework/sky-element/sky-element.sky View 1 chunk +0 lines, -195 lines 0 comments Download
D sky/framework/xmlhttprequest.sky View 1 chunk +0 lines, -132 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-23 22:52:23 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-23 22:52:49 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-02-23 23:09:41 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1870689dcf4d32b12325966708eecd1a1d76f996 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698