Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/clang/plugins/tests/overridden_methods.h

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/missing_ctor.txt ('k') | tools/clang/plugins/tests/overridden_methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/overridden_methods.h
diff --git a/tools/clang/plugins/tests/overridden_methods.h b/tools/clang/plugins/tests/overridden_methods.h
index 69ee100c48b0763722d0a96640e084ef9943d53d..c5af9140e70bd1845898826d427693fc8d5ac732 100644
--- a/tools/clang/plugins/tests/overridden_methods.h
+++ b/tools/clang/plugins/tests/overridden_methods.h
@@ -21,7 +21,7 @@ class BaseClass {
};
class InterimClass : public BaseClass {
- // Should warn about pure virtual methods.
+ // Should not warn about pure virtual methods.
virtual void SomeMethod() = 0;
};
@@ -42,12 +42,12 @@ class WebKitObserverImpl : blink::WebKitObserver {
class DerivedClass : public InterimClass,
public webkit_glue::WebKitObserverImpl {
public:
- // Should warn about destructors.
+ // Should not warn about destructors.
virtual ~DerivedClass() {}
// Should warn.
virtual void SomeMethod();
// Should not warn if marked as override.
- void SomeOtherMethod() override;
+ virtual void SomeOtherMethod() override;
// Should warn for inline implementations.
virtual void SomeInlineMethod() {}
// Should not warn if overriding a method whose origin is blink.
« no previous file with comments | « tools/clang/plugins/tests/missing_ctor.txt ('k') | tools/clang/plugins/tests/overridden_methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698