Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 6b254e0966bb8ad2de4ee746bf53e6f7cb3dc269..52a9c4351b47185261d76eba400f20aec9bb0b41 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -3099,16 +3099,11 @@ void GLES2DecoderImpl::DeleteFramebuffersHelper(
GetFramebuffer(client_ids[ii]);
if (framebuffer && !framebuffer->IsDeleted()) {
if (framebuffer == framebuffer_state_.bound_draw_framebuffer.get()) {
+ framebuffer_state_.bound_draw_framebuffer = NULL;
+ framebuffer_state_.clear_state_dirty = true;
GLenum target = supports_separate_framebuffer_binds ?
GL_DRAW_FRAMEBUFFER_EXT : GL_FRAMEBUFFER;
-
- // Unbind attachments on FBO before deletion.
- if (workarounds().unbind_attachments_on_bound_render_fbo_delete)
- framebuffer->DoUnbindGLAttachmentsForWorkaround(target);
-
glBindFramebufferEXT(target, GetBackbufferServiceId());
- framebuffer_state_.bound_draw_framebuffer = NULL;
- framebuffer_state_.clear_state_dirty = true;
}
if (framebuffer == framebuffer_state_.bound_read_framebuffer.get()) {
framebuffer_state_.bound_read_framebuffer = NULL;
@@ -12060,51 +12055,6 @@ error::Error GLES2DecoderImpl::HandleUniformBlockBinding(
return error::kNoError;
}
-error::Error GLES2DecoderImpl::HandleClientWaitSync(
- uint32_t immediate_data_size, const void* cmd_data) {
- if (!unsafe_es3_apis_enabled())
- return error::kUnknownCommand;
- const gles2::cmds::ClientWaitSync& c =
- *static_cast<const gles2::cmds::ClientWaitSync*>(cmd_data);
- GLuint sync = static_cast<GLuint>(c.sync);
- GLbitfield flags = static_cast<GLbitfield>(c.flags);
- GLuint64 timeout = GLES2Util::MapTwoUint32ToUint64(c.timeout_0, c.timeout_1);
- typedef cmds::ClientWaitSync::Result Result;
- Result* result_dst = GetSharedMemoryAs<Result*>(
- c.result_shm_id, c.result_shm_offset, sizeof(*result_dst));
- if (!result_dst) {
- return error::kOutOfBounds;
- }
- if (*result_dst != GL_WAIT_FAILED) {
- return error::kInvalidArguments;
- }
- GLsync service_sync = 0;
- if (!group_->GetSyncServiceId(sync, &service_sync)) {
- LOCAL_SET_GL_ERROR(GL_INVALID_VALUE, "ClientWaitSync", "invalid sync");
- return error::kNoError;
- }
- *result_dst = glClientWaitSync(service_sync, flags, timeout);
- return error::kNoError;
-}
-
-error::Error GLES2DecoderImpl::HandleWaitSync(
- uint32_t immediate_data_size, const void* cmd_data) {
- if (!unsafe_es3_apis_enabled())
- return error::kUnknownCommand;
- const gles2::cmds::WaitSync& c =
- *static_cast<const gles2::cmds::WaitSync*>(cmd_data);
- GLuint sync = static_cast<GLuint>(c.sync);
- GLbitfield flags = static_cast<GLbitfield>(c.flags);
- GLuint64 timeout = GLES2Util::MapTwoUint32ToUint64(c.timeout_0, c.timeout_1);
- GLsync service_sync = 0;
- if (!group_->GetSyncServiceId(sync, &service_sync)) {
- LOCAL_SET_GL_ERROR(GL_INVALID_VALUE, "WaitSync", "invalid sync");
- return error::kNoError;
- }
- glWaitSync(service_sync, flags, timeout);
- return error::kNoError;
-}
-
void GLES2DecoderImpl::OnTextureRefDetachedFromFramebuffer(
TextureRef* texture_ref) {
Texture* texture = texture_ref->texture();
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698