Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl.h

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/Config.h ('k') | tools/clang/blink_gc_plugin/tests/traceimpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/traceimpl.h
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl.h b/tools/clang/blink_gc_plugin/tests/traceimpl.h
index 64fae26be8649690bce7ce70da103cc34da7c706..26f4615b055d130ad1683355443a87bb2fa6b8ac 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl.h
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl.h
@@ -20,11 +20,11 @@ class TraceImplInlined : public GarbageCollected<TraceImplInlined> {
template <typename VisitorDispatcher>
void traceImpl(VisitorDispatcher visitor) {
- visitor->trace(x_);
+ visitor->trace(m_x);
}
private:
- Member<X> x_;
+ Member<X> m_x;
};
class TraceImplExtern : public GarbageCollected<TraceImplExtern> {
@@ -34,35 +34,8 @@ class TraceImplExtern : public GarbageCollected<TraceImplExtern> {
inline void traceImpl(VisitorDispatcher);
private:
- Member<X> x_;
+ Member<X> m_x;
};
-
-class Base : public GarbageCollected<Base> {
- public:
- virtual void trace(Visitor* visitor) {}
-};
-
-class TraceImplBaseInlined : public Base {
- public:
- void trace(Visitor* visitor) override { traceImpl(visitor); }
-
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
- Base::trace(visitor);
- }
-};
-
-class TraceImplBaseExtern : public Base {
- public:
- void trace(Visitor* visitor) override;
-
- template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher);
-
- private:
- Member<X> x_;
-};
-
}
#endif
« no previous file with comments | « tools/clang/blink_gc_plugin/Config.h ('k') | tools/clang/blink_gc_plugin/tests/traceimpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698