Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: ui/events/latency_info.h

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/gestures/gesture_provider_impl.cc ('k') | ui/events/latency_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/latency_info.h
diff --git a/ui/events/latency_info.h b/ui/events/latency_info.h
index b6724b86154ac8dce6948aa4d0ac697bfb768384..1a18f9b72382edef19c0c70f952f27a25234060a 100644
--- a/ui/events/latency_info.h
+++ b/ui/events/latency_info.h
@@ -25,25 +25,26 @@ enum LatencyComponentType {
// Timestamp when a scroll update for the main thread is begun.
INPUT_EVENT_LATENCY_BEGIN_SCROLL_UPDATE_MAIN_COMPONENT,
// ---------------------------NORMAL COMPONENT-------------------------------
+ // Timestamp when the scroll update gesture event is sent from RWH to
+ // renderer. In Aura, touch event's LatencyInfo is carried over to the gesture
+ // event. So gesture event's INPUT_EVENT_LATENCY_RWH_COMPONENT is the
+ // timestamp when its original touch events is sent from RWH to renderer.
+ // In non-aura platform, INPUT_EVENT_LATENCY_SCROLL_UPDATE_RWH_COMPONENT
+ // is the same as INPUT_EVENT_LATENCY_RWH_COMPONENT.
+ INPUT_EVENT_LATENCY_SCROLL_UPDATE_RWH_COMPONENT,
// The original timestamp of the touch event which converts to scroll update.
INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
- // The original timestamp of the touch event which converts to the *first*
- // scroll update in a scroll gesture sequence.
- INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
// Original timestamp for input event (e.g. timestamp from kernel).
INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT,
// Timestamp when the UI event is created.
INPUT_EVENT_LATENCY_UI_COMPONENT,
// This is special component indicating there is rendering scheduled for
- // the event associated with this LatencyInfo on main thread.
- INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_MAIN_COMPONENT,
- // This is special component indicating there is rendering scheduled for
- // the event associated with this LatencyInfo on impl thread.
- INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_IMPL_COMPONENT,
+ // the event associated with this LatencyInfo.
+ INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_COMPONENT,
// Timestamp when a scroll update is forwarded to the main thread.
INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT,
- // Timestamp when the event's ack is received by the RWH.
- INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT,
+ // Timestamp when the touch event is acked.
+ INPUT_EVENT_LATENCY_ACKED_TOUCH_COMPONENT,
// Frame number when a window snapshot was requested. The snapshot
// is taken when the rendering results actually reach the screen.
WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT,
@@ -53,13 +54,12 @@ enum LatencyComponentType {
WINDOW_OLD_SNAPSHOT_FRAME_NUMBER_COMPONENT,
// Timestamp when a tab is requested to be shown.
TAB_SHOW_COMPONENT,
- // Timestamp when the frame is swapped in renderer.
- INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT,
- // Timestamp of when the browser process receives a buffer swap notification
- // from the renderer.
- INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT,
+ // Timestamp of when the Browser process began compositing
+ INPUT_EVENT_BROWSER_COMPOSITE_COMPONENT,
+ // Timestamp of when the Browser process began swap buffers
+ INPUT_EVENT_BROWSER_SWAP_BUFFER_COMPONENT,
// Timestamp of when the gpu service began swap buffers, unlike
- // INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT which measures after.
+ // INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT which measure after
INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT,
// ---------------------------TERMINAL COMPONENT-----------------------------
// TERMINAL COMPONENT is when we show the latency end in chrome://tracing.
@@ -111,7 +111,7 @@ struct EVENTS_BASE_EXPORT LatencyInfo {
};
// Empirically determined constant based on a typical scroll sequence.
- enum { kTypicalMaxComponentsPerLatencyInfo = 10 };
+ enum { kTypicalMaxComponentsPerLatencyInfo = 9 };
enum { kMaxInputCoordinates = 2 };
« no previous file with comments | « ui/events/gestures/gesture_provider_impl.cc ('k') | ui/events/latency_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698