Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3512)

Unified Diff: cc/trees/layer_tree_host_common.cc

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_client.h ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_common.cc
diff --git a/cc/trees/layer_tree_host_common.cc b/cc/trees/layer_tree_host_common.cc
index 7a3b5adbab102d8c5c52b7b095cb4d760ce0b534..70c5037221d1979579ac149f2fe0190b205834a9 100644
--- a/cc/trees/layer_tree_host_common.cc
+++ b/cc/trees/layer_tree_host_common.cc
@@ -161,8 +161,8 @@ static gfx::Vector2dF ComputeChangeOfBasisTranslation(
}
enum TranslateRectDirection {
- TRANSLATE_RECT_DIRECTION_TO_ANCESTOR,
- TRANSLATE_RECT_DIRECTION_TO_DESCENDANT
+ TranslateRectDirectionToAncestor,
+ TranslateRectDirectionToDescendant
};
template <typename LayerType>
@@ -172,7 +172,7 @@ static gfx::Rect TranslateRectToTargetSpace(const LayerType& ancestor_layer,
TranslateRectDirection direction) {
gfx::Vector2dF translation = ComputeChangeOfBasisTranslation<LayerType>(
ancestor_layer, descendant_layer);
- if (direction == TRANSLATE_RECT_DIRECTION_TO_DESCENDANT)
+ if (direction == TranslateRectDirectionToDescendant)
translation.Scale(-1.f);
return gfx::ToEnclosingRect(
gfx::RectF(rect.origin() + translation, rect.size()));
@@ -211,16 +211,20 @@ static void UpdateClipRectsForClipChild(
// clip rects will want to be in its target space, not ours.
if (clip_parent == layer->clip_parent()) {
*clip_rect_in_parent_target_space = TranslateRectToTargetSpace<LayerType>(
- *clip_parent, *layer->parent(), *clip_rect_in_parent_target_space,
- TRANSLATE_RECT_DIRECTION_TO_DESCENDANT);
+ *clip_parent,
+ *layer->parent(),
+ *clip_rect_in_parent_target_space,
+ TranslateRectDirectionToDescendant);
} else {
// If we're being clipped by our scroll parent, we must translate through
// our common ancestor. This happens to be our parent, so it is sufficent to
// translate from our clip parent's space to the space of its ancestor (our
// parent).
- *clip_rect_in_parent_target_space = TranslateRectToTargetSpace<LayerType>(
- *layer->parent(), *clip_parent, *clip_rect_in_parent_target_space,
- TRANSLATE_RECT_DIRECTION_TO_ANCESTOR);
+ *clip_rect_in_parent_target_space =
+ TranslateRectToTargetSpace<LayerType>(*layer->parent(),
+ *clip_parent,
+ *clip_rect_in_parent_target_space,
+ TranslateRectDirectionToAncestor);
}
}
@@ -282,8 +286,10 @@ void UpdateAccumulatedSurfaceState(
// so we'll need to transform it before it is applied.
if (layer->clip_parent()) {
clip_rect = TranslateRectToTargetSpace<LayerType>(
- *layer->clip_parent(), *layer, clip_rect,
- TRANSLATE_RECT_DIRECTION_TO_DESCENDANT);
+ *layer->clip_parent(),
+ *layer,
+ clip_rect,
+ TranslateRectDirectionToDescendant);
}
target_rect.Intersect(clip_rect);
}
@@ -1197,30 +1203,12 @@ struct PreCalculateMetaInformationRecursiveData {
}
};
-static bool ValidateRenderSurface(LayerImpl* layer) {
- // This test verifies that there are no cases where a LayerImpl needs
- // a render surface, but doesn't have one.
- if (layer->render_surface())
- return true;
-
- return layer->filters().IsEmpty() && layer->background_filters().IsEmpty() &&
- !layer->mask_layer() && !layer->replica_layer() &&
- !IsRootLayer(layer) && !layer->is_root_for_isolated_group() &&
- !layer->HasCopyRequest();
-}
-
-static bool ValidateRenderSurface(Layer* layer) {
- return true;
-}
-
// Recursively walks the layer tree to compute any information that is needed
// before doing the main recursion.
template <typename LayerType>
static void PreCalculateMetaInformation(
LayerType* layer,
PreCalculateMetaInformationRecursiveData* recursive_data) {
- DCHECK(ValidateRenderSurface(layer));
-
layer->draw_properties().sorted_for_recursion = false;
layer->draw_properties().has_child_with_a_scroll_parent = false;
« no previous file with comments | « cc/trees/layer_tree_host_client.h ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698