Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/jstemplate/jstemplate.js

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/jstemplate/jsevalcontext.js ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/jstemplate/jstemplate.js
diff --git a/third_party/jstemplate/jstemplate.js b/third_party/jstemplate/jstemplate.js
index 449a31ca352f0aab782f94c730138ee9e07e4852..b4c154fd37c6498313f81509f4190fed0e015d59 100644
--- a/third_party/jstemplate/jstemplate.js
+++ b/third_party/jstemplate/jstemplate.js
@@ -552,6 +552,9 @@ JstProcessor.prototype.jstProcessInner_ = function(context, template) {
* @param {Element} template The currently processed node of the template.
*
* @param {Function} select The javascript expression to evaluate.
+ *
+ * @notypecheck FIXME(hmitchell): See OCL6434950. instance and value need
+ * type checks.
*/
JstProcessor.prototype.jstSelect_ = function(context, template, select) {
var me = this;
@@ -583,7 +586,6 @@ JstProcessor.prototype.jstSelect_ = function(context, template, select) {
var multipleEmpty = (multiple && count == 0);
if (multiple) {
- value = /** @type Array */(value);
if (multipleEmpty) {
// For an empty array, keep the first template instance and mark
// it last. Remove all other template instances.
@@ -936,7 +938,7 @@ function jstLoadTemplate_(doc, html, targetId) {
* @param {Array} values The current input context, the array of
* values of which the template node will render one instance.
*
- * @param {number|string} index The index of this template node in values.
+ * @param {number} index The index of this template node in values.
*/
function jstSetInstance(template, values, index) {
if (index == jsLength(values) - 1) {
« no previous file with comments | « third_party/jstemplate/jsevalcontext.js ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698