Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.cpp ('k') | tools/clang/plugins/tests/virtual_base_method_also_final.flags » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from overridden_methods.cpp:5: 1 In file included from overridden_methods.cpp:5:
2 ./overridden_methods.h:25:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
3 virtual void SomeMethod() = 0;
4 ^
5 override
6 ./overridden_methods.h:46:26: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual ~DerivedClass() {}
8 ^
9 override
10 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 2 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
11 virtual void SomeMethod(); 3 virtual void SomeMethod();
12 ^ 4 ^
13 override 5 override
14 ./overridden_methods.h:52:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 6 ./overridden_methods.h:52:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
15 virtual void SomeInlineMethod() {} 7 virtual void SomeInlineMethod() {}
16 ^ 8 ^
17 override 9 override
18 ./overridden_methods.h:56:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 10 ./overridden_methods.h:56:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
19 virtual void SomeConstMethod() const {} 11 virtual void SomeConstMethod() const {}
(...skipping 12 matching lines...) Expand all
32 ^ 24 ^
33 override 25 override
34 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 26 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
35 virtual void SomeMethodWithComment(); // This is a comment. 27 virtual void SomeMethodWithComment(); // This is a comment.
36 ^ 28 ^
37 override 29 override
38 ./overridden_methods.h:67:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 30 ./overridden_methods.h:67:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
39 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 31 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
40 ^ 32 ^
41 override 33 override
42 overridden_methods.cpp:15:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
43 virtual void SomeMethod() = 0;
44 ^
45 override
46 overridden_methods.cpp:22:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
47 virtual ~ImplementationDerivedClass() {}
48 ^
49 override
50 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 34 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
51 virtual void SomeMethod(); 35 virtual void SomeMethod();
52 ^ 36 ^
53 override 37 override
54 overridden_methods.cpp:28:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 38 overridden_methods.cpp:28:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
55 virtual void SomeInlineMethod() {} 39 virtual void SomeInlineMethod() {}
56 ^ 40 ^
57 override 41 override
58 overridden_methods.cpp:32:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 42 overridden_methods.cpp:32:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
59 virtual void SomeConstMethod() const {} 43 virtual void SomeConstMethod() const {}
(...skipping 12 matching lines...) Expand all
72 ^ 56 ^
73 override 57 override
74 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 58 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
75 virtual void SomeMethodWithComment(); // This is a comment. 59 virtual void SomeMethodWithComment(); // This is a comment.
76 ^ 60 ^
77 override 61 override
78 overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 62 overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
79 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 63 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
80 ^ 64 ^
81 override 65 override
82 20 warnings generated. 66 16 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.cpp ('k') | tools/clang/plugins/tests/virtual_base_method_also_final.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698