Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Side by Side Diff: base/version_unittest.cc

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/version.cc ('k') | base/win/pe_image.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace { 9 namespace {
10 10
(...skipping 23 matching lines...) Expand all
34 bool success; 34 bool success;
35 } cases[] = { 35 } cases[] = {
36 {"", 0, false}, 36 {"", 0, false},
37 {" ", 0, false}, 37 {" ", 0, false},
38 {"\t", 0, false}, 38 {"\t", 0, false},
39 {"\n", 0, false}, 39 {"\n", 0, false},
40 {" ", 0, false}, 40 {" ", 0, false},
41 {".", 0, false}, 41 {".", 0, false},
42 {" . ", 0, false}, 42 {" . ", 0, false},
43 {"0", 1, true}, 43 {"0", 1, true},
44 {"0.", 0, false},
45 {"0.0", 2, true}, 44 {"0.0", 2, true},
46 {"65537.0", 0, false}, 45 {"65537.0", 0, false},
47 {"-1.0", 0, false}, 46 {"-1.0", 0, false},
48 {"1.-1.0", 0, false}, 47 {"1.-1.0", 0, false},
49 {"1,--1.0", 0, false},
50 {"+1.0", 0, false}, 48 {"+1.0", 0, false},
51 {"1.+1.0", 0, false}, 49 {"1.+1.0", 0, false},
52 {"1+1.0", 0, false},
53 {"++1.0", 0, false},
54 {"1.0a", 0, false}, 50 {"1.0a", 0, false},
55 {"1.2.3.4.5.6.7.8.9.0", 10, true}, 51 {"1.2.3.4.5.6.7.8.9.0", 10, true},
56 {"02.1", 0, false}, 52 {"02.1", 0, false},
57 {"0.01", 2, true},
58 {"f.1", 0, false}, 53 {"f.1", 0, false},
59 {"15.007.20011", 3, true},
60 }; 54 };
61 55
62 for (size_t i = 0; i < arraysize(cases); ++i) { 56 for (size_t i = 0; i < arraysize(cases); ++i) {
63 Version version(cases[i].input); 57 Version version(cases[i].input);
64 EXPECT_EQ(cases[i].success, version.IsValid()); 58 EXPECT_EQ(cases[i].success, version.IsValid());
65 if (cases[i].success) 59 if (cases[i].success)
66 EXPECT_EQ(cases[i].parts, version.components().size()); 60 EXPECT_EQ(cases[i].parts, version.components().size());
67 } 61 }
68 } 62 }
69 63
70 TEST(VersionTest, Compare) { 64 TEST(VersionTest, Compare) {
71 static const struct version_compare { 65 static const struct version_compare {
72 const char* lhs; 66 const char* lhs;
73 const char* rhs; 67 const char* rhs;
74 int expected; 68 int expected;
75 } cases[] = { 69 } cases[] = {
76 {"1.0", "1.0", 0}, 70 {"1.0", "1.0", 0},
77 {"1.0", "0.0", 1}, 71 {"1.0", "0.0", 1},
78 {"1.0", "2.0", -1}, 72 {"1.0", "2.0", -1},
79 {"1.0", "1.1", -1}, 73 {"1.0", "1.1", -1},
80 {"1.1", "1.0", 1}, 74 {"1.1", "1.0", 1},
81 {"1.0", "1.0.1", -1}, 75 {"1.0", "1.0.1", -1},
82 {"1.1", "1.0.1", 1}, 76 {"1.1", "1.0.1", 1},
83 {"1.1", "1.0.1", 1}, 77 {"1.1", "1.0.1", 1},
84 {"1.0.0", "1.0", 0}, 78 {"1.0.0", "1.0", 0},
85 {"1.0.3", "1.0.20", -1}, 79 {"1.0.3", "1.0.20", -1},
86 {"11.0.10", "15.007.20011", -1},
87 }; 80 };
88 for (size_t i = 0; i < arraysize(cases); ++i) { 81 for (size_t i = 0; i < arraysize(cases); ++i) {
89 Version lhs(cases[i].lhs); 82 Version lhs(cases[i].lhs);
90 Version rhs(cases[i].rhs); 83 Version rhs(cases[i].rhs);
91 EXPECT_EQ(lhs.CompareTo(rhs), cases[i].expected) << 84 EXPECT_EQ(lhs.CompareTo(rhs), cases[i].expected) <<
92 cases[i].lhs << " ? " << cases[i].rhs; 85 cases[i].lhs << " ? " << cases[i].rhs;
93 86
94 EXPECT_EQ(lhs.IsOlderThan(cases[i].rhs), (cases[i].expected == -1)); 87 EXPECT_EQ(lhs.IsOlderThan(cases[i].rhs), (cases[i].expected == -1));
95 } 88 }
96 } 89 }
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 {"*", false}, 132 {"*", false},
140 {"*.2", false}, 133 {"*.2", false},
141 }; 134 };
142 for (size_t i = 0; i < arraysize(cases); ++i) { 135 for (size_t i = 0; i < arraysize(cases); ++i) {
143 EXPECT_EQ(Version::IsValidWildcardString(cases[i].version), 136 EXPECT_EQ(Version::IsValidWildcardString(cases[i].version),
144 cases[i].expected) << cases[i].version << "?" << cases[i].expected; 137 cases[i].expected) << cases[i].version << "?" << cases[i].expected;
145 } 138 }
146 } 139 }
147 140
148 } // namespace 141 } // namespace
OLDNEW
« no previous file with comments | « base/version.cc ('k') | base/win/pe_image.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698