Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: base/trace_event/process_memory_dump.cc

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/trace_event/process_memory_dump.h ('k') | base/trace_event/process_memory_totals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/trace_event/process_memory_dump.h" 5 #include "base/trace_event/process_memory_dump.h"
6 6
7 #include "base/trace_event/process_memory_totals.h" 7 #include "base/json/json_writer.h"
8 #include "base/trace_event/trace_event_argument.h" 8 #include "base/values.h"
9 9
10 namespace base { 10 namespace base {
11 namespace trace_event { 11 namespace trace_event {
12 12
13 ProcessMemoryDump::ProcessMemoryDump() : has_process_totals_(false) { 13 ProcessMemoryDump::ProcessMemoryDump() {
14 } 14 }
15 15
16 ProcessMemoryDump::~ProcessMemoryDump() { 16 ProcessMemoryDump::~ProcessMemoryDump() {
17 } 17 }
18 18
19 void ProcessMemoryDump::AsValueInto(TracedValue* value) const { 19 void ProcessMemoryDump::AppendAsTraceFormat(std::string* out) const {
20 // Build up the [dumper name] -> [value] dictionary. 20 // Build up the [dumper name] -> [serialized snapshot] JSON dictionary.
21 if (has_process_totals_) { 21 DictionaryValue dict;
22 value->BeginDictionary("process_totals"); 22 std::string json_dict;
23 process_totals_.AsValueInto(value); 23 // TODO(primiano): this will append here the actual dumps from the dumpers.
24 value->EndDictionary(); 24 base::JSONWriter::Write(&dict, &json_dict);
25 } 25 *out += json_dict;
26 } 26 }
27 27
28 } // namespace trace_event 28 } // namespace trace_event
29 } // namespace base 29 } // namespace base
OLDNEW
« no previous file with comments | « base/trace_event/process_memory_dump.h ('k') | base/trace_event/process_memory_totals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698