Register application connections under their post-redirect URL.

shell/application_manager/fetcher.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SHELL_APPLICATION_MANAGER_FETCHER_H_
 #define SHELL_APPLICATION_MANAGER_FETCHER_H_
 
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 
@@ skipping 22 matching lines @@
  public:
   // The param will be NULL in the case where the content could not be fetched.
   // Reasons include:
   // - network error
   // - 4x or 5x HTTP errors
   typedef base::Callback<void(scoped_ptr<Fetcher>)> FetchCallback;
 
   Fetcher(const FetchCallback& fetch_callback);
   virtual ~Fetcher();
 
+  // Returns the original URL that was fetched.

[DaveMoore, 2015/02/24 20:42:59]

Wouldn't it be better to just have one method on fetcher called GetURL()? The
local one would always return the requested one and the network implementation
would return the redirect url if there was one, otherwise the requested.

[Aaron Boodman, 2015/02/24 21:48:25]

Whether a redirect happened is important information -- it affects what
ApplicationManager does. Current CL encodes this information in whether
GetRedirectURL() returns a non-empty URL. It could also be encoded in a separate
bit ... but I kinda prefer it as it is.

+  virtual const GURL& GetURL() const = 0;
+
+  // If the fetch resulted in a redirect, this returns the final URL after all
+  // redirects. Otherwise, it returns an empty URL.
+  virtual GURL GetRedirectURL() const = 0;
+
   virtual URLResponsePtr AsURLResponse(base::TaskRunner* task_runner,
                                        uint32_t skip) = 0;
 
   virtual void AsPath(
       base::TaskRunner* task_runner,
       base::Callback<void(const base::FilePath&, bool)> callback) = 0;
 
   virtual std::string MimeType() = 0;
 
   virtual bool HasMojoMagic() = 0;
 
   virtual bool PeekFirstLine(std::string* line) = 0;
 
   bool PeekContentHandler(std::string* mojo_shebang,
                           GURL* mojo_content_handler_url);
 
  protected:
   static const char kMojoMagic[];
   static const size_t kMaxShebangLength;
 
   FetchCallback loader_callback_;
 };
 
 }  // namespace mojo
 
 #endif  // SHELL_APPLICATION_MANAGER_FETCHER_H_