Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 951603002: Rename inner index variable to avoid variable shadowing. (Closed)

Created:
5 years, 10 months ago by brucedawson
Modified:
5 years, 10 months ago
Reviewers:
kojii, eae
CC:
blink-reviews, Dominik Röttsches, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename inner index variable to avoid variable shadowing. Two loops were recently added that used 'i' as an index variable, inside an outer loop that also used 'i'. This isn't a bug, but can be confusing. This change renames the inner 'i' variables to 'j'. The variable shadowing was introduced in this change: https://codereview.chromium.org/932033002 This was found by the /analyze builder BUG=427616 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/platform/fonts/opentype/OpenTypeVerticalData.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
brucedawson
5 years, 10 months ago (2015-02-23 21:06:29 UTC) #2
eae
LGTM
5 years, 10 months ago (2015-02-23 21:07:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951603002/1
5 years, 10 months ago (2015-02-23 21:52:15 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 23:55:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190698

Powered by Google App Engine
This is Rietveld 408576698