Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 951593003: Revert of Move base_dir to user_story_set, remove file_path. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move base_dir to user_story_set, remove file_path. (patchset #4 id:60001 of https://codereview.chromium.org/946473002/) Reason for revert: breaks on main waterfall, i.e. http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/21577/steps/telemetry_unittests/logs/stdio AssertionError: 'E:\\b\\build\\slave\\Win_7_Tests_x64__1_\\build\\src\\tools\\telemetry\\telemetry\\user_story\\user_story_set_unittest.pyc' != 'E:\\b\\build\\slave\\Win_7_Tests_x64__1_\\build\\src\\tools\\telemetry\\telemetry\\user_story\\user_story_set_unittest.py' not sure why this fails on main waterfall but not trybots? Original issue's description: > Move base_dir to user_story_set, remove file_path. > > BUG=454531 > > Committed: https://crrev.com/65ff7d22f8986ab2832045af09160dc753e40c5f > Cr-Commit-Position: refs/heads/master@{#317632} TBR=chrishenry@google.com,dtu@chromium.org,sullivan@chromium.org,nednguyen@google.com,aiolos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454531 Committed: https://crrev.com/14042b4980d2bcf8c2a070ebdfde646626990d23 Cr-Commit-Position: refs/heads/master@{#317665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -37 lines) Patch
M tools/telemetry/telemetry/page/page_set.py View 2 chunks +17 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 2 chunks +2 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set_unittest.py View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Move base_dir to user_story_set, remove file_path.
5 years, 10 months ago (2015-02-23 22:17:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951593003/1
5 years, 10 months ago (2015-02-23 22:18:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 22:20:03 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 22:20:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14042b4980d2bcf8c2a070ebdfde646626990d23
Cr-Commit-Position: refs/heads/master@{#317665}

Powered by Google App Engine
This is Rietveld 408576698