[turbofan] remove dependence of InstructionBlock on BasicBlock

[turbofan] remove dependence of InstructionBlock on BasicBlock

BUG=

Committed: https://crrev.com/e928c9d52b68c6a2873f72297508d12a88215aaa
Cr-Commit-Position: refs/heads/master@{#26859}

[Michael Starzinger, 2015-02-25 14:59:36]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-02-25 14:59:38]

LGTM if comments are addressed. I like it!

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction...
File src/compiler/instruction-selector.h (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction...
src/compiler/instruction-selector.h:24: class BasicBlock;
nit: Please alpha-sort.

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction...
src/compiler/instruction.h:695: // TODO(dcarney): remove this class and just use
an uint32_t.
suggestion: Not sure about this TODO, better ask Benedikt about his opinion.

https://codereview.chromium.org/951553005/diff/80001/src/compiler/jump-thread...
File src/compiler/jump-threading.cc (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/jump-thread...
src/compiler/jump-threading.cc:12: typedef RpoNumber RpoNumber;
nit: Redundant typedef is redundant.

https://codereview.chromium.org/951553005/diff/80001/src/compiler/schedule.cc
File src/compiler/schedule.cc (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/schedule.cc...
src/compiler/schedule.cc:316: for (BasicBlock* block : *s.rpo_order()) {
Since this printer already iterates the rpo_order vector, it can only be applied
on a sealed schedule. Hence we can also print "B{rpo_number}" here as well.

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
File test/cctest/compiler/test-instruction.cc (left):

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
test/cctest/compiler/test-instruction.cc:134: CHECK_EQ(block->id().ToInt(),
R.BlockAt(block)->id().ToInt());
Can we preserve this check? It should still hold, right?

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
File test/cctest/compiler/test-jump-threading.cc (right):

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
test/cctest/compiler/test-jump-threading.cc:16: typedef RpoNumber RpoNumber;
nit: Redundant typedef is redundant.

[dcarney, 2015-02-25 16:08:26]

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction...
File src/compiler/instruction-selector.h (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction...
src/compiler/instruction-selector.h:24: class BasicBlock;
On 2015/02/25 14:59:37, Michael Starzinger wrote:
> nit: Please alpha-sort.

Done.

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction...
src/compiler/instruction.h:695: // TODO(dcarney): remove this class and just use
an uint32_t.
On 2015/02/25 14:59:37, Michael Starzinger wrote:
> suggestion: Not sure about this TODO, better ask Benedikt about his opinion.

removed TODO for now.

https://codereview.chromium.org/951553005/diff/80001/src/compiler/jump-thread...
File src/compiler/jump-threading.cc (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/jump-thread...
src/compiler/jump-threading.cc:12: typedef RpoNumber RpoNumber;
On 2015/02/25 14:59:37, Michael Starzinger wrote:
> nit: Redundant typedef is redundant.

Done.

https://codereview.chromium.org/951553005/diff/80001/src/compiler/schedule.cc
File src/compiler/schedule.cc (right):

https://codereview.chromium.org/951553005/diff/80001/src/compiler/schedule.cc...
src/compiler/schedule.cc:316: for (BasicBlock* block : *s.rpo_order()) {
On 2015/02/25 14:59:37, Michael Starzinger wrote:
> Since this printer already iterates the rpo_order vector, it can only be
applied
> on a sealed schedule. Hence we can also print "B{rpo_number}" here as well.

sweet. done

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
File test/cctest/compiler/test-instruction.cc (left):

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
test/cctest/compiler/test-instruction.cc:134: CHECK_EQ(block->id().ToInt(),
R.BlockAt(block)->id().ToInt());
On 2015/02/25 14:59:37, Michael Starzinger wrote:
> Can we preserve this check? It should still hold, right?

Done.

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
File test/cctest/compiler/test-jump-threading.cc (right):

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
test/cctest/compiler/test-jump-threading.cc:16: typedef RpoNumber RpoNumber;
On 2015/02/25 14:59:37, Michael Starzinger wrote:
> nit: Redundant typedef is redundant.

Done.

[dcarney, 2015-02-25 16:08:32]

The CQ bit was checked by dcarney@chromium.org

[dcarney, 2015-02-25 16:08:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/951553005/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-02-25 16:09:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951553005/100001

[commit-bot: I haz the power, 2015-02-25 16:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 16:14:36]

Try jobs failed on following builders:
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/3252)

[dcarney, 2015-02-25 16:17:41]

The CQ bit was checked by dcarney@chromium.org

[dcarney, 2015-02-25 16:17:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/951553005/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-02-25 16:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951553005/120001

[dcarney, 2015-02-25 16:19:04]

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
File test/cctest/compiler/test-instruction.cc (left):

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
test/cctest/compiler/test-instruction.cc:134: CHECK_EQ(block->id().ToInt(),
R.BlockAt(block)->id().ToInt());
On 2015/02/25 16:08:26, dcarney wrote:
> On 2015/02/25 14:59:37, Michael Starzinger wrote:
> > Can we preserve this check? It should still hold, right?
> 
> Done.

Acutally, undone.  This is not a BasicBlock, and no longer carries the id info.

[Michael Starzinger, 2015-02-25 16:24:23]

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
File test/cctest/compiler/test-instruction.cc (left):

https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/tes...
test/cctest/compiler/test-instruction.cc:134: CHECK_EQ(block->id().ToInt(),
R.BlockAt(block)->id().ToInt());
On 2015/02/25 16:19:04, dcarney wrote:
> On 2015/02/25 16:08:26, dcarney wrote:
> > On 2015/02/25 14:59:37, Michael Starzinger wrote:
> > > Can we preserve this check? It should still hold, right?
> > 
> > Done.
> 
> Acutally, undone.  This is not a BasicBlock, and no longer carries the id
info.

Acknowledged. Ah, yeah, now I see it. Sorry for the noise.

[commit-bot: I haz the power, 2015-02-25 16:37:56]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-02-25 16:38:10]

Patchset 7 (id:??) landed as
https://crrev.com/e928c9d52b68c6a2873f72297508d12a88215aaa
Cr-Commit-Position: refs/heads/master@{#26859}