Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 951553004: Fix chromiumos breakage for gn_all. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chromiumos breakage for gn_all. The gn_all target in all.gyp is attempting to build ':image_diff#host', which I think may not work correctly in a chromeos==1 build. I think the '...#host' syntax should probably only be used on the android port (looks like that's what content_shell.gypi does). Though, given that we're building content_shell, we shouldn't need the image_diff dependency at all, so I'm just deleting it outright. TBR=abodenha@chromium.org, brettw@chromium.org, hshi@chromium.org NOTRY=true NOTREECHECKS=true BUG=461602 Committed: https://crrev.com/88ba00883a3d5f9b8b9fbc498d444d4f61b7560f Cr-Commit-Position: refs/heads/master@{#317953}

Patch Set 1 : real fix #

Patch Set 2 : fix symupload as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/all.gyp View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-25 01:15:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951553004/20001
5 years, 10 months ago (2015-02-25 01:16:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951553004/40001
5 years, 10 months ago (2015-02-25 02:12:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951553004/40001
5 years, 10 months ago (2015-02-25 02:14:38 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-25 02:15:49 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 02:16:17 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88ba00883a3d5f9b8b9fbc498d444d4f61b7560f
Cr-Commit-Position: refs/heads/master@{#317953}

Powered by Google App Engine
This is Rietveld 408576698